Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Module avm-res-compute-virtualmachine #717

Merged
merged 119 commits into from
Jan 10, 2024

Conversation

rahalan
Copy link
Contributor

@rahalan rahalan commented Dec 10, 2023

Add CARML VM module to AVM

avm.res.compute.virtual-machine

@rahalan rahalan marked this pull request as draft January 5, 2024 17:54
auto-merge was automatically disabled January 5, 2024 17:54

Pull request was converted to draft

@rahalan rahalan marked this pull request as ready for review January 5, 2024 19:12
@rahalan rahalan enabled auto-merge (squash) January 5, 2024 19:13
@eriqua
Copy link
Contributor

eriqua commented Jan 9, 2024

@rahalan this is good for me related to changes we discussed. I'll leave the last word on the module to @AlexanderSehr who requested changes there.

@AlexanderSehr AlexanderSehr self-requested a review January 10, 2024 08:39
@rahalan rahalan merged commit e27dde7 into Azure:main Jan 10, 2024
9 checks passed
@rahalan rahalan deleted the users/rahalan/AlignVmToAVM2 branch January 10, 2024 10:08
AlexanderSehr added a commit that referenced this pull request Jan 12, 2024
…ed `main.bicep` (#766)

## Description

- Fixed resolution of local file references ignoring files not named
`main.bicep`
- [x] TODO: Re-run on all modules and after #717 is merged

Successful test with to-be VM module:

![image](https://github.com/Azure/bicep-registry-modules/assets/5365358/5913af24-cb01-4f03-983c-0b81b864b4f8)

---------

Co-authored-by: Erika Gressi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants