Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try removing track 1 deps #26900

Closed
wants to merge 1 commit into from
Closed

Try removing track 1 deps #26900

wants to merge 1 commit into from

Conversation

isra-fel
Copy link
Member

No description provided.

Copy link

azure-client-tools-bot-prd bot commented Dec 18, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

@VeryEarly VeryEarly closed this Dec 18, 2024
@isra-fel
Copy link
Member Author

CI passed after the track 1 sdks are removed. We can safely assume that all sdk-based test projects don't have to depend on any track 1 management plain sdks.
For data plain it's another story, because we can't replace the current solution (test runner creates instance of sdk client and replaces real client) with the better solution (test runner adds http interceptor to the real client without referencing the concrete type), and that's because the creation of data plain sdks may not call client factory, so we may not have the chance to append http interceptor.

@isra-fel isra-fel deleted the test-testfx branch December 18, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants