-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal] QuorumReader: Adds Test Coverage for Direct Package BugFix #4970
Open
NaluTripician
wants to merge
8
commits into
master
Choose a base branch
from
users/nalutripician/QuroumReaderFixTestCoverage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Internal] QuorumReader: Adds Test Coverage for Direct Package BugFix #4970
NaluTripician
wants to merge
8
commits into
master
from
users/nalutripician/QuroumReaderFixTestCoverage
+291
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaluTripician
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel and
kirillg
as code owners
January 17, 2025 20:25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
NaluTripician
changed the title
Tests
[Internal] QuorumReader: Adds Test Coverage for Direct Package BugFix
Jan 17, 2025
ananth7592
previously approved these changes
Jan 23, 2025
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosItemIntegrationTests.cs
Outdated
Show resolved
Hide resolved
ananth7592
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Adds Test coverage for quorum reader bug fix. Refactors Live account test setup so it can reuse existing databases for all tests.
This issue was fixed with the recent upgrade of the Direct package to 3.36.6, the original issue is #4440
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4440