Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Drop - Arc K8s Secret Store extension #223
New Drop - Arc K8s Secret Store extension #223
Changes from 29 commits
383539e
f8e007a
f2238c0
ec30ffc
4d9d800
97338ed
0d7c97d
5abe5d1
39d1927
8f6d5b8
a22f72c
bd24c5d
c8cec65
02f830c
5864e91
c8b5a34
79e94e1
cf24d07
6fa6e23
2917086
4271d0c
0e37b39
df2077a
41004b4
a09e291
3a91c72
a5fbf84
8c13118
1e5c21f
7b7e228
7fecbb7
c923df8
ec2acf6
07a993b
1338c2c
f35bd67
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High level question- why is everything automated via the script for this drop but for other similar drops like ACSA (https://github.com/Azure/arc_jumpstart_drops/tree/main/script_automation/arc_edge_volumes_cloudsync_ubuntu_k3_single), only some configuration is automated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our goal is to ensure all the necessary infrastructure is in place so that users never encounter failures and can easily experiment with the feature. Providing step-by-step instructions would be akin to documentation. Adding @likamrat for thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zaidmohd is correct. Also, unlike this Drop that was developed by a core Jumpstart maintainer, the ACSA one was contributed by ACSA team. When we develop in-house, we follow our design principles mentioned by @zaidmohd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great - thank you for explaining