ArcBox - Update windows password to optional #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zaidmohd
commented
Feb 11, 2025
•
zaidmohd
commented
- Update windows password to optional
- Add Bastion Key Vault reference for password
Repo migration for Supermarket
janegilring
requested changes
Feb 12, 2025
There was a problem hiding this comment.
Content looks good.
I was thinking whether it would make sense to move the screenshot of the Key Vault to this section as this is where it will be needed?
and maybe a reminder in this section that the password can be retrieved from Key Vault if not specified during deployment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.