Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export/publish built-in managed gateway apis #515

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: export/publish built-in managed gateway apis #515

wants to merge 1 commit into from

Conversation

daviian
Copy link
Contributor

@daviian daviian commented Mar 29, 2024 •
edited
Loading

resolves #501

@daviian
Copy link
Contributor Author

daviian commented Mar 29, 2024

@microsoft-github-policy-service agree company="Cloudflight"

@waelkdouh
Copy link
Contributor

Hi we just released v6 release candidate. Can you please try to apply your PR on the new code base?

@waelkdouh
Copy link
Contributor

@daviian will you be able to resubmit the PR against the new v6 code base?

@daviian
Copy link
Contributor Author

daviian commented Jul 9, 2024

@waelkdouh I'll try to find some time this week to check out the new code base and apply my changes.

@daviian
Copy link
Contributor Author

daviian commented Jul 10, 2024 •
edited
Loading

@waelkdouh I need some clarification about this line https://github.com/Azure/apiops/blob/main/tools/code/publisher/App.cs#L51.
Isn't the order important when importing changed files? As in, you cannot assign a gateway to an API that has not yet been created before.
How is this ensured in v6?

I think I've found the answer.
Please let me know if the solution is fine or needs changes.

@daviian daviian force-pushed the managed-gateway branch 2 times, most recently from c384212 to c1a3b0e Compare July 10, 2024 11:30
@waelkdouh waelkdouh requested a review from guythetechie July 10, 2024 11:45
@daviian daviian force-pushed the managed-gateway branch 4 times, most recently from 89d9b9c to 1ec4b7a Compare August 7, 2024 14:07
@daviian
Copy link
Contributor Author

daviian commented Aug 7, 2024

I've updated the PR so that the conflicts from recent merges have been resolved.
@guythetechie can you have a look at the PR please?

@daviian daviian force-pushed the managed-gateway branch 2 times, most recently from b1725b7 to 37e5985 Compare August 23, 2024 06:13
@daviian
Copy link
Contributor Author

daviian commented Oct 14, 2024

Is there any chance this can be removed soonish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guythetechie guythetechie Awaiting requested review from guythetechie

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question] How to not include "Managed" gateway by default when publishing APIs
2 participants
@daviian @waelkdouh