Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement remove provisioner for azure devops task #62

Merged
merged 15 commits into from
Dec 11, 2023
Merged

Enhancement remove provisioner for azure devops task #62

merged 15 commits into from
Dec 11, 2023

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Dec 9, 2023 •
edited
Loading

Overview/Summary

This PR removes the dependency on the MS DevLabs task for Azure DevOps. It also tidies and refactors the code a little.

This PR fixes/adds/changes/removes

  1. Bug Report resource type "terraform_data" is not supported by provider "terraform.io/builtin/terraform" #61
  2. Bug: Accelerator fails if Azure DevOps extension is not already installed.  #37

Breaking Changes

None

Testing Evidence

E2E testing and local testing carried out.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate jaredfholgate self-assigned this Dec 9, 2023
@jaredfholgate jaredfholgate added the PR: Safe to test 🧪 Enables running of End to End Tests label Dec 9, 2023
@jaredfholgate jaredfholgate marked this pull request as ready for review December 9, 2023 22:28
@jaredfholgate jaredfholgate merged commit 115ab56 into main Dec 11, 2023
21 checks passed
@jaredfholgate jaredfholgate deleted the enhancement-remove-provisioner-for-azure-devops-task branch December 11, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-FFFFFF matt-FFFFFF matt-FFFFFF approved these changes

@luke-taylor luke-taylor Awaiting requested review from luke-taylor

Assignees

@jaredfholgate jaredfholgate

Labels
PR: Safe to test 🧪 Enables running of End to End Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredfholgate @matt-FFFFFF