Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Dragos arm-ttk id from resourceId validation errors #11726

Merged
merged 6 commits into from
Feb 3, 2025
Merged

Fixing Dragos arm-ttk id from resourceId validation errors #11726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
03de70a
Mitigating arm-ttk errors that docs say we can ignore, but partner ce…
dragosinc-sentinel Jan 28, 2025
b649f3e
Fixing custom detail as id bypass resulted in name that was too long
dragosinc-sentinel Jan 28, 2025
b7147d6
Bumping analytic version due to id name field change.
dragosinc-sentinel Jan 29, 2025
921bd21
Merge branch 'Azure:master' into master
dragosinc-sentinel Jan 30, 2025
207a2e8
Solution packaged
v-prasadboke Feb 3, 2025
adb76c4
Merge branch 'master' into pr/11726
v-prasadboke Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Solutions/Dragos/Analytic Rules/DragosNotifiction.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ alertDetailsOverride:
- alertProperty: ProductName
value: AlertProductName
customDetails:
DragosNotificationId: id
DragosIdentifier: id
DragosSeverity: severity
DragosDetectionQuads: detectionQuads
DragosCreatedAt: createdAt
Expand All @@ -60,6 +60,6 @@ incidentConfiguration:
lookbackDuration: PT1H
matchingMethod: Selected
groupByCustomDetails:
- DragosNotificationId
version: 1.0.0
- DragosIdentifier
version: 1.0.1
kind: Scheduled
Binary file modified Solutions/Dragos/Package/3.0.0.zip
View file
Open in desktop
Binary file not shown.
60 changes: 30 additions & 30 deletions Solutions/Dragos/Package/mainTemplate.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Solutions/Dragos/Parsers/DragosNotificationsToSentinel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ FunctionQuery: |
let existingIncidents = SecurityAlert
| where ProductName == "Dragos"
| extend CustomDetails=tostring(parse_json(ExtendedProperties)["Custom Details"])
| extend id = toint(extract_json("$.DragosNotificationId[0]", CustomDetails))
| extend id = toint(extract_json("$.DragosIdentifier[0]", CustomDetails))
| project-keep SystemAlertId, id;
union isfuzzy=true DragosPushNotificationsToSentinel, DragosPullNotificationsToSentinel
| join kind=leftouter (existingIncidents) on id
Expand Down
2 changes: 1 addition & 1 deletion Solutions/Dragos/Parsers/DragosPullNotificationsToSentinel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ FunctionQuery: |
let existingIncidents = SecurityAlert
| where ProductName == "Dragos"
| extend CustomDetails=tostring(parse_json(ExtendedProperties)["Custom Details"])
| extend id = toint(extract_json("$.DragosNotificationId[0]", CustomDetails))
| extend id = toint(extract_json("$.DragosIdentifier[0]", CustomDetails))
| project-keep SystemAlertId, id;
DragosAlerts_CL
| extend detectionQuads=strcat_array(detectionQuads, ",")
Expand Down
2 changes: 1 addition & 1 deletion Solutions/Dragos/SolutionMetadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"publisherId": "dragosinc1734451815609",
"offerId": "azure-sentinel-solution-dragos",
"offerId": "microsoft-sentinel-solution-dragos",
"firstPublishDate": "2025-01-23",
"lastPublishDate": "2025-01-23",
"providers": [
Expand Down
Loading