Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Custom Entity mappings, these have not been used for years. #11611

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

shainw
Copy link
Contributor

@shainw shainw commented Dec 27, 2024

Change(s):

  • Removed custom entity mappings

Reason for Change(s):

  • Not needed, has not been used for years

Version Updated:

  • Yes

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

Copy link

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

@v-atulyadav v-atulyadav added Solution Solution specialty review needed Analytic Rules labels Dec 30, 2024
rahul0216
rahul0216 previously approved these changes Dec 30, 2024
Copy link
Contributor

@rahul0216 rahul0216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@rahul0216
Copy link
Contributor

@v-atulyadav @v-shukore Please take care of packaging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytic Rules Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants