Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Cribl to Microsoft Azure Solutions Repo #10912

Merged
merged 25 commits into from
Aug 21, 2024
Merged

Conversation

amiracle
Copy link
Contributor

@amiracle amiracle commented Aug 1, 2024

Change(s):

Cribl Steam Solution added
Added a new folder named "Cribl" in the "Solutions" directory
Created a new Cribl sample files in the Samples Folder
Added Cribl-Logo.svg to "Logos" directory
Reasons for Change(s):
Cribl Stream Solution being added into the Microsoft Azure Sentinel repository.
Version 1.0.0 Added.
Tested and validated Solution file with preview function in Sentinel.

@microsoft-github-policy-service agree [company=“Cribl"]
@microsoft-github-policy-service agree

@amiracle amiracle requested review from a team as code owners August 1, 2024 19:21
@v-prasadboke v-prasadboke self-assigned this Aug 2, 2024
@v-prasadboke v-prasadboke added the Solution Solution specialty review needed label Aug 2, 2024
Copy link
Contributor Author

@amiracle amiracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated Files to pass the validation.

Copy link
Contributor Author

@amiracle amiracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Made:
Corrected Sample files added them into a JSON array
Repaired the mainTemplate.json and createUiDefinition.json to work with validation
Updated Solution_Cribl.json
Added files to 1.0.0.zip file
Updated Parsers and updated their names.
Updated SolutionMetadata.json

Copy link
Contributor Author

@amiracle amiracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the parser file with the fix to the query field. updated image svg file.

Copy link
Contributor Author

@amiracle amiracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated Solutions under Data Connectors and SolutionMetadta.

@v-prasadboke
Copy link
Contributor

Hello @amiracle,

  • Please add graph queries to the Data connector.

  • Add id property to the parsers

  • Also check on Solution metadata's Domain.

Refer this Solution for more clarification.
https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/Akamai%20Security%20Events

Copy link
Contributor Author

@amiracle amiracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates

Copy link
Contributor Author

@amiracle amiracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated updates to the solution and made changes to be compliant with solution validations.

@v-prasadboke
Copy link
Contributor

Hello @amiracle, Please create custom table schema named as CriblInternal_CL and CriblInternal at location
https://github.com/Azure/Azure-Sentinel/tree/master/.script/tests/KqlvalidationsTests/CustomTables

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this Data connector needed. We already have 1 data connector in solution folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This data connector was going to be used to connect third party data into Microsoft Sentinel similar to what the syslog connector is doing. The Connector in the Cribl Solution folder is specifically for the data generated by the Cribl Stream solution.

@v-prasadboke
Copy link
Contributor

Hello @amiracle, we are waiting for your reply

@v-prasadboke
Copy link
Contributor

Hello @amiracle, Can you please work on the above requested changes.

@amiracle
Copy link
Contributor Author

Hello @amiracle,

  • Please add graph queries to the Data connector.
  • Add id property to the parsers
  • Also check on Solution metadata's Domain.

Refer this Solution for more clarification. https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/Akamai%20Security%20Events

This has been completed.

  • The graph queries have been added to the Data connector.
  • Id's have been added to the parsers.
  • The Solution domain of Security - Other has been added.

@amiracle
Copy link
Contributor Author

Hello @amiracle, Please create custom table schema named as CriblInternal_CL and CriblInternal at location https://github.com/Azure/Azure-Sentinel/tree/master/.script/tests/KqlvalidationsTests/CustomTables

All of the custom tables have been added to the repo:

  • CriblAccess_CL
  • CriblAudit_CL
  • CriblInternal_CL
  • CriblUIAccess_CL

@amiracle
Copy link
Contributor Author

@v-prasadboke - I'm trying to decipher the error messages as to why my code is not passing validation. Can you please explain the error codes so that I can properly address them and get this solution added to the repo?

@v-prasadboke
Copy link
Contributor

Hello @amiracle, Can we get on a call for this.
Please share your time zone and availability so that we can plan for the same.

You can ping me on teams too if needed - [email protected]

@v-prasadboke
Copy link
Contributor

reference for parser : https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/Snowflake/Parsers/Snowflake.yaml

V3 tool : C:\GitHub\Azure-Sentinel\Tools\Create-Azure-Sentinel-Solution\V3

@v-dvedak v-dvedak merged commit 8eaa881 into Azure:master Aug 21, 2024
32 checks passed
@v-prasadboke v-prasadboke added the Connector Connector specialty review needed label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connector Connector specialty review needed Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants