Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctera branch #10889

Closed
wants to merge 30 commits into from
Closed

Ctera branch #10889

wants to merge 30 commits into from

Conversation

roberteliass
Copy link
Contributor

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@roberteliass roberteliass requested review from a team as code owners July 29, 2024 09:14
@roberteliass
Copy link
Contributor Author

roberteliass commented Jul 29, 2024 via email

@roberteliass
Copy link
Contributor Author

roberteliass commented Jul 29, 2024 via email

@v-prasadboke v-prasadboke added the Solution Solution specialty review needed label Jul 29, 2024
{
"Name": "CTERA",
"Author": "CTERA Networks - [email protected]",
"Logo": "<img src=\"https://raw.githubusercontent.com/Azure/Azure-Sentinel/master/Solutions/CTERA/Data%20Connectors/Logo/CTERA_Networks_logo.svg\" width=\"75px\" height=\"75px\">",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @roberteliass, Logo should be in 'Logos' folder, not 'Solution/Logo'. Please move and update link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@v-visodadasi
Copy link
Contributor

Please try to resolve the validation errors from your end.
Also share sample data for testing the content of the solution.

@roberteliass roberteliass requested a review from a team as a code owner July 31, 2024 23:03
@roberteliass
Copy link
Contributor Author

roberteliass commented Jul 31, 2024 via email

@roberteliass
Copy link
Contributor Author

roberteliass commented Aug 4, 2024 via email

@v-visodadasi
Copy link
Contributor

Please note that the Solution Metadata file should not be formatted in this manner. For reference, Please see https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/AIShield%20AI%20Security%20Monitoring/SolutionMetadata.json

@v-visodadasi
Copy link
Contributor

Please resolve the validation errors

@roberteliass
Copy link
Contributor Author

Please try to resolve the validation errors from your end. Also share sample data for testing the content of the solution.

I can't understand why the validation is failing neither on the logo, nor for the rest of the validations.
Regarding the sample data, can I supply the syslog events?

@roberteliass
Copy link
Contributor Author

roberteliass commented Aug 6, 2024 via email

@v-prasadboke
Copy link
Contributor

Hello @roberteliass, Can you provide me write access to your branch.
Need to push some required commits.

You can do this by inviting me as an contributor to your branch.

Thanks,
Prasad

@roberteliass
Copy link
Contributor Author

Hello @roberteliass, Can you provide me write access to your branch. Need to push some required commits.

You can do this by inviting me as an contributor to your branch.

Thanks, Prasad

I provided the access, let me know if you have it.

In addition please let me know what is the status on my request to better understand the validation failures.
When I try seeing the log, I can't have access to it.

"title": "CTERA Syslog",
"publisher": "CTERA",
"description": "Ingest CTERA syslog data into Microsoft Sentinel",
"additionalRequirementBanner": "None ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @roberteliass, Please add a short description markdown to the data connector.
For ref: https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/Theom/Data%20Connectors/Theom.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, will commit shortly

@v-prasadboke
Copy link
Contributor

Please do share sample data to test the content of the solution

@roberteliass
Copy link
Contributor Author

roberteliass commented Aug 13, 2024 via email

@roberteliass
Copy link
Contributor Author

roberteliass commented Sep 11, 2024

All arm-ttk issues were addressed, please process this request it's pending for over a week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants