SinecSecurityGuard_tb_reviewed #10828

XiFneg · 2024-07-17T03:20:53Z

Required items, please complete

Change(s):

See guidance below

Reason for Change(s):

See guidance below

Version Updated:

Required only for Detections/Analytic Rule templates
See guidance below

Testing Completed:

See guidance below

Checked that the validations are passing and have addressed any issues that are present:

See guidance below

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

Updated syntax for XYZ.yaml

Reason for Change(s):

New schema used for XYZ.yaml
Resolves ISSUE Add Logstash required version to Readme file #1234

Version updated:

Yes
Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

Guidance for Detection checks

General contribution guidance

PR validation troubleshooting

XiFneg · 2024-07-17T05:56:04Z

@microsoft-github-policy-service agree company="Siemens AG" From: microsoft-github-policy-service[bot] ***@***.***> Sent: Wednesday, July 17, 2024 12:31 PM To: Azure/Azure-Sentinel ***@***.***> Cc: Liu, Xi Feng (T CST SAR-CN) ***@***.***>; Mention ***@***.***> Subject: Re: [Azure/Azure-Sentinel] SinecSecurityGuard_tb_reviewed (PR #10828) @XiFneg<https://github.com/XiFneg> please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information. @microsoft-github-policy-service agree [company="{your company}"] Options: * (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer. @microsoft-github-policy-service agree * (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term "You" includes me and my employer. @microsoft-github-policy-service agree company="Microsoft" Contributor License Agreement Contribution License Agreement This Contribution License Agreement ("Agreement") is agreed to by the party signing below ("You"), and conveys certain license rights to Microsoft Corporation and its affiliates ("Microsoft") for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below. 1. Definitions. "Code" means the computer software code, whether in human-readable or machine-executable form, that is delivered by You to Microsoft under this Agreement. "Project" means any of the projects owned or managed by Microsoft and offered under a license approved by the Open Source Initiative (www.opensource.org<http://www.opensource.org/>). "Submit" is the act of uploading, submitting, transmitting, or distributing code or other content to any Project, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of discussing and improving that Project, but excluding communication that is conspicuously marked or otherwise designated in writing by You as "Not a Submission." "Submission" means the Code and any other copyrightable material Submitted by You, including any associated comments and documentation. 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any Project. This Agreement covers any and all Submissions that You, now or in the future (except as described in Section 4 below), Submit to any Project. 3. Originality of Work. You represent that each of Your Submissions is entirely Your original work. Should You wish to Submit materials that are not Your original work, You may Submit them separately to the Project if You (a) retain all copyright and license information that was in the materials as You received them, (b) in the description accompanying Your Submission, include the phrase "Submission containing materials of a third party:" followed by the names of the third party and any licenses or other restrictions of which You are aware, and (c) follow any other instructions in the Project's written guidelines concerning Submissions. 4. Your Employer. References to "employer" in this Agreement include Your employer or anyone else for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your Submission is made in the course of Your work for an employer or Your employer has intellectual property rights in Your Submission by contract or applicable law, You must secure permission from Your employer to make the Submission before signing this Agreement. In that case, the term "You" in this Agreement will refer to You and the employer collectively. If You change employers in the future and desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement and secure permission from the new employer before Submitting those Submissions. 5. Licenses. * Copyright License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third parties. * Patent License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under Your patent claims that are necessarily infringed by the Submission or the combination of the Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and import or otherwise dispose of the Submission alone or with the Project. * Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are granted by implication, exhaustion, estoppel or otherwise. 1. Representations and Warranties. You represent that You are legally entitled to grant the above licenses. You represent that each of Your Submissions is entirely Your original work (except as You may have disclosed under Section 3). You represent that You have secured permission from Your employer to make the Submission in cases where Your Submission is made in the course of Your work for Your employer or Your employer has intellectual property rights in Your Submission by contract or applicable law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You have the necessary authority to bind the listed employer to the obligations contained in this Agreement. You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE. 2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which You later become aware that would make Your representations in this Agreement inaccurate in any respect. 3. Information about Submissions. You agree that contributions to Projects and information about contributions may be maintained indefinitely and disclosed publicly, including Your name and other information that You submit with Your Submission. 4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County, Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all defenses of lack of personal jurisdiction and forum non-conveniens. 5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and supersedes any and all prior agreements, understandings or communications, written or oral, between the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft. - Reply to this email directly, view it on GitHub<#10828 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWGLDN7J4O5K447UXEM25D3ZMXXQDAVCNFSM6AAAAABK7X3XP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZSGM4DOOJUGY>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

XiFneg · 2024-07-17T09:34:40Z

why "kqlValidations" always return "Template in is not valid" as below pic:

I generate the UUID via python script:

import uuid
new_uuid = uuid.uuid4()  # Generates a random UUID.
print(new_uuid)

v-prasadboke · 2024-07-19T06:40:25Z

Hello @XiFneg, Solution is missing with input file which is required to package the solution. Please create one.

https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/Armis/Data/Solution_Armis.json

You can refer this input file for more clarification.

Also I've committed some required changes.

Thanks,
Prasad

XiFneg · 2024-07-19T08:20:25Z

Hello @XiFneg, Solution is missing with input file which is required to package the solution. Please create one.

https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/Armis/Data/Solution_Armis.json

You can refer this input file for more clarification.

Also I've committed some required changes.

Thanks, Prasad

Thank you, it looks the pipeline check-ups all passed, what should we do next please?

v-prasadboke · 2024-07-23T08:23:26Z

Hello @XiFneg, Just wanted confirm the Data connector added to the solution is it of type CCP

XiFneg · 2024-07-31T03:49:13Z

Thank you, just updated the dataConnector, please take a look. And one more question, do I also need to put a DCR? Because I don't see any DCR from your example. From: v-prasadboke ***@***.***> Sent: Tuesday, July 30, 2024 5:13 PM To: Azure/Azure-Sentinel ***@***.***> Cc: Liu, Xi Feng (T CST SAR-CN) ***@***.***>; Mention ***@***.***> Subject: Re: [Azure/Azure-Sentinel] SinecSecurityGuard_tb_reviewed (PR #10828) Heres an example of normal data connector. https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/Amazon%20Web%20Services/Data%20Connectors/template_AWS.json Please correct template of your data connector - Reply to this email directly, view it on GitHub<#10828 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWGLDNYMXP7OYQYYBMYWTW3ZO5KLDAVCNFSM6AAAAABK7X3XP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJXHA3DONJWHE>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

v-prasadboke · 2024-08-02T10:24:22Z

Solutions/Sinec Security Guard/SolutionMetadata.json

+	},
+	"support": {
+	  "name": "Siemens AG",
+	  "email": "Siemens AG",


Please correct email address

XiFneg · 2024-08-05T08:54:55Z

Just added email address. From: v-prasadboke ***@***.***> Sent: Friday, August 2, 2024 6:25 PM To: Azure/Azure-Sentinel ***@***.***> Cc: Liu, Xi Feng (T CST SAR-CN) ***@***.***>; Mention ***@***.***> Subject: Re: [Azure/Azure-Sentinel] SinecSecurityGuard_tb_reviewed (PR #10828) @v-prasadboke commented on this pull request.

________________________________ In Solutions/Sinec Security Guard/SolutionMetadata.json<#10828 (comment)>:

@@ -0,0 +1,16 @@

+{ + "publisherId": "siemensplmsoftware", + "offerId": "azure-sentinel-solution-SSG", + "firstPublishDate": "2024-07-15", + "providers": ["Siemens AG"], + "categories": { + "domains" : ["cybersecurity", "Cloud-based"], + "verticals": ["Industrial","OT","Shop Floors"] + }, + "support": { + "name": "Siemens AG", + "email": "Siemens AG", Please correct email address - Reply to this email directly, view it on GitHub<#10828 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWGLDN2TNMTEJZ36QSYQJMTZPNM7BAVCNFSM6AAAAABK7X3XP2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMJVGI3TCMZRGI>. You are receiving this because you were mentioned.Message ID: ***@***.***>

v-prasadboke · 2024-08-07T08:44:44Z

Solutions/Sinec Security Guard/SolutionMetadata.json

-		"domains" : ["cybersecurity", "Cloud-based"],
-		"verticals": ["Industrial","OT","Shop Floors"]
+		"domains" : ["Security - Network"],
+		"verticals": ["NDR"]


Hello @XiFneg, This is an invalid vertical. Please go through this doc
https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/sentinel/sentinel-solutions.md?msclkid=9a240b52b11411ec99ae6736bd089c4a#categories-for-microsoft-sentinel-out-of-the-box-content-and-solutions

XiFneg · 2024-08-07T09:27:41Z

Thanks, just fixed the category and vertical. But one last issue left I've no idea how to fix it, I am pretty sure I followed the same format mentioned in "Connector_REST_API_template.json" The error msg: "2024-08-07T09:13:14.1959216Z Data Connector Validation Failed. File path: Solutions/Sinec Security Guard/Data Connectors/data_connector_GenericUI.json. Error message: Provided permissions does not match with REST_API Template. Please refer template ***/blob/master/DataConnectors/Templates/Connector_REST_API_template.json " From: v-prasadboke ***@***.***> Sent: Wednesday, August 7, 2024 4:45 PM To: Azure/Azure-Sentinel ***@***.***> Cc: Liu, Xi Feng (T CST SAR-CN) ***@***.***>; Mention ***@***.***> Subject: Re: [Azure/Azure-Sentinel] SinecSecurityGuard_tb_reviewed (PR #10828) @v-prasadboke commented on this pull request.

________________________________ In Solutions/Sinec Security Guard/SolutionMetadata.json<#10828 (comment)>:

@@ -4,8 +4,8 @@

"firstPublishDate": "2024-07-15", "providers": ["Siemens AG"], "categories": { - "domains" : ["cybersecurity", "Cloud-based"], - "verticals": ["Industrial","OT","Shop Floors"] + "domains" : ["Security - Network"], + "verticals": ["NDR"] Hello @XiFneg<https://github.com/XiFneg>, This is an invalid vertical. Please go through this doc https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/sentinel/sentinel-solutions.md?msclkid=9a240b52b11411ec99ae6736bd089c4a#categories-for-microsoft-sentinel-out-of-the-box-content-and-solutions - Reply to this email directly, view it on GitHub<#10828 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWGLDNYOR4FUXZMNC7KPB7TZQHNBLAVCNFSM6AAAAABK7X3XP2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMRTGQYTGNBWGA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

…e-Sentinel into pr/10828

v-prasadboke · 2024-08-12T13:26:25Z

Hello @XiFneg, I have added missing permissions can you please check once.

XiFneg · 2024-08-13T07:16:49Z

Hello, everything is ok except the logo part is blank when testing UI, would this be figured out after the solution's released? From: v-prasadboke ***@***.***> Sent: Monday, August 12, 2024 9:27 PM To: Azure/Azure-Sentinel ***@***.***> Cc: Liu, Xi Feng (T CST SAR-CN) ***@***.***>; Mention ***@***.***> Subject: Re: [Azure/Azure-Sentinel] SinecSecurityGuard_tb_reviewed (PR #10828) Hello @XiFneg<https://github.com/XiFneg>, I have added missing permissions can you please check once. - Reply to this email directly, view it on GitHub<#10828 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWGLDN2MSLDBOVJM4LHX27LZRCZZTAVCNFSM6AAAAABK7X3XP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBTHE4TGMJQGU>. You are receiving this because you were mentioned.Message ID: ***@***.***>

v-prasadboke · 2024-08-14T09:50:31Z

Hello, everything is ok except the logo part is blank when testing UI, would this be figured out after the solution's released? From: v-prasadboke @.> Sent: Monday, August 12, 2024 9:27 PM To: Azure/Azure-Sentinel @.> Cc: Liu, Xi Feng (T CST SAR-CN) @.>; Mention @.> Subject: Re: [Azure/Azure-Sentinel] SinecSecurityGuard_tb_reviewed (PR #10828) Hello @XiFneg https://github.com/XiFneg, I have added missing permissions can you please check once. - Reply to this email directly, view it on GitHub<#10828 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWGLDN2MSLDBOVJM4LHX27LZRCZZTAVCNFSM6AAAAABK7X3XP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBTHE4TGMJQGU. You are receiving this because you were mentioned.Message ID: @.***>

yes @XiFneg, That is because the url is pointing to master
And the logo is not in master branch yet

XiFneg · 2024-08-15T01:22:46Z

Thanks, I think it's good to proceed, thank you for supporting. From: v-prasadboke ***@***.***> Sent: Wednesday, August 14, 2024 5:51 PM To: Azure/Azure-Sentinel ***@***.***> Cc: Liu, Xi Feng (T CST SAR-CN) ***@***.***>; Mention ***@***.***> Subject: Re: [Azure/Azure-Sentinel] SinecSecurityGuard_tb_reviewed (PR #10828) Hello, everything is ok except the logo part is blank when testing UI, would this be figured out after the solution's released? From: v-prasadboke @.> Sent: Monday, August 12, 2024 9:27 PM To: Azure/Azure-Sentinel @.> Cc: Liu, Xi Feng (T CST SAR-CN) @.>; Mention @.> Subject: Re: [Azure/Azure-Sentinel] SinecSecurityGuard_tb_reviewed (PR #10828<#10828>) Hello @XiFneg<https://github.com/XiFneg>https://github.com/XiFneg, I have added missing permissions can you please check once. - Reply to this email directly, view it on GitHub<#10828 (comment)<#10828 (comment)>>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWGLDN2MSLDBOVJM4LHX27LZRCZZTAVCNFSM6AAAAABK7X3XP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBTHE4TGMJQGU. You are receiving this because you were mentioned.Message ID: @.***> yes @XiFneg<https://github.com/XiFneg>, That is because the url is pointing to master And the logo is not in master branch yet - Reply to this email directly, view it on GitHub<#10828 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWGLDN6E3VO4YUI2TDBIL7LZRMSADAVCNFSM6AAAAABK7X3XP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBYGMZDKMZWGY>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

XiFneg · 2024-08-19T02:47:48Z

Hello, according to https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/README.mdcan , can I move to step-3 (Publish your solution) now? Thanks. From: Liu, Xi Feng (T CST SAR-CN) Sent: Thursday, August 15, 2024 9:23 AM To: Azure/Azure-Sentinel ***@***.***>; Azure/Azure-Sentinel ***@***.***> Cc: Mention ***@***.***> Subject: RE: [Azure/Azure-Sentinel] SinecSecurityGuard_tb_reviewed (PR #10828) Thanks, I think it's good to proceed, thank you for supporting. From: v-prasadboke ***@***.******@***.***>> Sent: Wednesday, August 14, 2024 5:51 PM To: Azure/Azure-Sentinel ***@***.******@***.***>> Cc: Liu, Xi Feng (T CST SAR-CN) ***@***.******@***.***>>; Mention ***@***.******@***.***>> Subject: Re: [Azure/Azure-Sentinel] SinecSecurityGuard_tb_reviewed (PR #10828) Hello, everything is ok except the logo part is blank when testing UI, would this be figured out after the solution's released? From: v-prasadboke @.> Sent: Monday, August 12, 2024 9:27 PM To: Azure/Azure-Sentinel @.> Cc: Liu, Xi Feng (T CST SAR-CN) @.>; Mention @.> Subject: Re: [Azure/Azure-Sentinel] SinecSecurityGuard_tb_reviewed (PR #10828<#10828>) Hello @XiFneg<https://github.com/XiFneg>https://github.com/XiFneg, I have added missing permissions can you please check once. - Reply to this email directly, view it on GitHub<#10828 (comment)<#10828 (comment)>>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWGLDN2MSLDBOVJM4LHX27LZRCZZTAVCNFSM6AAAAABK7X3XP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBTHE4TGMJQGU. You are receiving this because you were mentioned.Message ID: @.***> yes @XiFneg<https://github.com/XiFneg>, That is because the url is pointing to master And the logo is not in master branch yet - Reply to this email directly, view it on GitHub<#10828 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWGLDN6E3VO4YUI2TDBIL7LZRMSADAVCNFSM6AAAAABK7X3XP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBYGMZDKMZWGY>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

v-prasadboke · 2024-08-20T10:23:27Z

Hello @XiFneg, Let this PR get merged than you can publish your solution on Marketplace

XiFneg · 2024-11-18T07:52:33Z

@v-prasadboke Is the Zip file for 3.0.0 still the lastest one? Or should there be a 3.0.1 file? thank you!

SinecSecurityGuard_tb_reviewed

13e6646

XiFneg requested review from a team as code owners July 17, 2024 03:20

v-atulyadav assigned v-prasadboke Jul 17, 2024

v-atulyadav added the Solution Solution specialty review needed label Jul 17, 2024

XiFneg added 4 commits July 17, 2024 15:24

SinecSecurityGuard_tb_reviewed

1cbbaa0

SinecSecurityGuard_tb_reviewed_v0.3

a7724c9

SinecSecurityGuard_tb_reviewed_v0.4

bf303cd

SinecSecurityGuard_tb_reviewed_v0.5

2d3b622

XiFneg and others added 9 commits July 18, 2024 09:37

SinecSecurityGuard_tb_reviewed_v0.6

d9aa0cf

SinecSecurityGuard_tb_reviewed_v0.7

3707420

SinecSecurityGuard_tb_reviewed_v0.8

713eda3

SinecSecurityGuard_tb_reviewed_v0.9

4214c9a

SinecSecurityGuard_tb_reviewed_v0.91

6213687

updated dataConnector

61a4200

Update SINECSecurityGuard_CL.json

c92e167

Update SSG_Azure_Sentinel_analytic_rule.yaml

4d3aad8

Corrected Logo

9aced9c

v-prasadboke and others added 5 commits July 19, 2024 12:11

Create ReleaseNotes.md

224c220

rename SVG add solution

3e74b54

Solution added SVG name changed

5925b6c

Solution added SVG name changed 2 more time

79bba60

SVG name changed

af51fed

publisher id changed

6d9626b

XiFneg added 5 commits July 31, 2024 09:32

changed to normal dataConnector

f04ad78

changed to normal dataConnector & schema

d3a628e

changed to normal dataConnector & schema

e033909

changed to normal dataConnector & schema

49ef1b9

changed to normal dataConnector & schema

048c03d

v-prasadboke reviewed Aug 2, 2024

View reviewed changes

Email-address added

42bc2ea

v-prasadboke and others added 4 commits August 6, 2024 17:18

Update data_connector_GenericUI.json

bfc37a8

Solution packaged

861b181

fixing packaging issues

31554a0

fixing packaging issues

082a8fa

v-prasadboke reviewed Aug 7, 2024

View reviewed changes

fixing packaging issues

13ebf66

v-prasadboke added 4 commits August 8, 2024 14:30

Merge branch 'master' into pr/10828

3c70f24

Merge branch 'sinec-security-guard' of https://github.com/XiFneg/Azur…

8499331

…e-Sentinel into pr/10828

Update data_connector_GenericUI.json

dca978d

Merge branch 'master' into pr/10828

0f84350

v-prasadboke approved these changes Aug 20, 2024

View reviewed changes

v-atulyadav approved these changes Aug 20, 2024

View reviewed changes

v-atulyadav merged commit 066c288 into Azure:master Aug 20, 2024
35 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SinecSecurityGuard_tb_reviewed #10828

SinecSecurityGuard_tb_reviewed #10828

XiFneg commented Jul 17, 2024

XiFneg commented Jul 17, 2024 via email

XiFneg commented Jul 17, 2024

v-prasadboke commented Jul 19, 2024

XiFneg commented Jul 19, 2024

v-prasadboke commented Jul 23, 2024

XiFneg commented Jul 31, 2024 via email

v-prasadboke Aug 2, 2024

XiFneg commented Aug 5, 2024 via email

v-prasadboke Aug 7, 2024

XiFneg commented Aug 7, 2024 via email

v-prasadboke commented Aug 12, 2024

XiFneg commented Aug 13, 2024 via email

v-prasadboke commented Aug 14, 2024

XiFneg commented Aug 15, 2024 via email

XiFneg commented Aug 19, 2024 via email

v-prasadboke commented Aug 20, 2024

XiFneg commented Nov 18, 2024

SinecSecurityGuard_tb_reviewed #10828

SinecSecurityGuard_tb_reviewed #10828

Conversation

XiFneg commented Jul 17, 2024

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

XiFneg commented Jul 17, 2024 via email

XiFneg commented Jul 17, 2024

v-prasadboke commented Jul 19, 2024

XiFneg commented Jul 19, 2024

v-prasadboke commented Jul 23, 2024

XiFneg commented Jul 31, 2024 via email

v-prasadboke Aug 2, 2024

Choose a reason for hiding this comment

XiFneg commented Aug 5, 2024 via email

v-prasadboke Aug 7, 2024

Choose a reason for hiding this comment

XiFneg commented Aug 7, 2024 via email

v-prasadboke commented Aug 12, 2024

XiFneg commented Aug 13, 2024 via email

v-prasadboke commented Aug 14, 2024

XiFneg commented Aug 15, 2024 via email

XiFneg commented Aug 19, 2024 via email

v-prasadboke commented Aug 20, 2024

XiFneg commented Nov 18, 2024