Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retiring legacy setting Core.AllInOneTemplate #517

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Retiring legacy setting Core.AllInOneTemplate #517

merged 2 commits into from
Jan 3, 2022

Conversation

Jefajers
Copy link
Member

@Jefajers Jefajers commented Jan 3, 2022

Overview/Summary

Retiring legacy setting Core.AllInOneTemplate from codebase.

Fixes #515

This PR fixes/adds/changes/removes

  1. Updates settings.md to reflect the change.
  2. Removes the setting from Core.ps1.
  3. Removes the processing of the setting from Get-AzOpsResourceDefinition.ps1.

Breaking Changes

N/A

Testing Evidence

Have performed Pull with the setting Core.AllInOneTemplate set to True and without it. Processing completes without errors.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers Jefajers requested a review from a team as a code owner January 3, 2022 11:12
@Jefajers Jefajers temporarily deployed to test January 3, 2022 11:12 Inactive
@Jefajers Jefajers changed the title cleanup Retiring legacy setting Core.AllInOneTemplate Jan 3, 2022
@Jefajers Jefajers temporarily deployed to test January 3, 2022 11:38 Inactive
@Jefajers Jefajers mentioned this pull request Jan 3, 2022
Merged
daltondhcp
daltondhcp approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@daltondhcp daltondhcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Jefajers Jefajers merged commit a461cee into Azure:main Jan 3, 2022
@Jefajers Jefajers deleted the decomission-allinone branch January 3, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltondhcp daltondhcp daltondhcp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decommission Core.AllInOneTemplate setting
2 participants
@Jefajers @daltondhcp