Makefile: add openshift-goimports, remove old verify #4083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
mociarain,
kimorris27,
tsatam,
bitoku,
fahlmant and
sankur-codes
as code owners
stevekuznetsov
commented
Feb 5, 2025
stevekuznetsov
force-pushed
the
skuznets/openshift-goimports
branch
2 times, most recently
from
8b7e40d to
ef0851b
Compare
|
Please rebase pull request. |
The openshift-goimports formatter is superior to the old strategy of verifying import groups since: - it is more flexible, allowing configuration flags to be passed that specify which groups need to exist and what order they should be in - it has an automatic formatter built in, so no humans will ever have to make manual changes to fix things - it runs in microseconds or milliseconds, so adding it to a pre-commit hook has little to no downside Signed-off-by: Steve Kuznetsov <[email protected]>
No need to copy-paste the formatting and import ordering line in every single generation argument, it's easy enough to just run it in the generate target. Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/openshift-goimports
branch
from
ef0851b to
87a7913
Compare
stevekuznetsov
force-pushed
the
skuznets/openshift-goimports
branch
2 times, most recently
from
352f84a to
b650c29
Compare
Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/openshift-goimports
branch
from
b650c29 to
2ade564
Compare
kimorris27
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile: add openshift-goimports, remove old verify
The openshift-goimports formatter is superior to the old strategy of
verifying import groups since:
specify which groups need to exist and what order they should be in
make manual changes to fix things
hook has little to no downside
Signed-off-by: Steve Kuznetsov [email protected]
*: format imports
Signed-off-by: Steve Kuznetsov [email protected]