[ARO-9582] Increase storage suffix length #4019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitoku
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
mociarain,
kimorris27,
tsatam and
fahlmant
as code owners
bitoku
changed the title
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Increased the length of the storage suffix generated from 5 to 10 characters for improved uniqueness.
kimorris27
approved these changes
Jan 2, 2025
cadenmarchese
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased the length of the storage suffix generated from 5 to 10 characters for improved uniqueness.
Which issue this PR addresses:
https://issues.redhat.com/browse/ARO-9582
What this PR does / why we need it:
We sometimes see CIF with the error "StorageAccountAlreadyTaken".
According to the document https://learn.microsoft.com/en-us/azure/storage/common/storage-account-overview storage account is unique within Azure, and our random storage account suffix is now 31^5 kinds.
Considering the number of clusters, it's too small.
This PR increases the length of suffix to 10 and lower the probability of collision.
Test plan for issue:
e2e
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
cluster creation