Extend pull secret controller unit test to cover Degraded status cond… #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbossis
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
mociarain,
kimorris27,
tsatam,
bitoku and
fahlmant
as code owners
kimorris27
requested changes
Dec 13, 2024
pkg/operator/controllers/pullsecret/pullsecret_controller_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Kipp Morris <[email protected]>
Co-authored-by: Kipp Morris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
https://issues.redhat.com/browse/ARO-13079
What this PR does / why we need it:
Extend pull secret controller unit tests with negative unit test case so that we know the controller's Reconcile function sets the appropriate controller state in response to function failure, which is expected to cause controller to enter a Degraded state. Potentially, an approach of Reconcile function failures on-demand for client.Client attempts to Update k8s objects can be re-used for other controllers.
Test plan for issue:
[x] Unit Test Cases
[] Local Cluster Creation
[] CI
[] E2E
Are there unit tests?
Yes, https://github.com/Azure/ARO-RP/blob/master/pkg/operator/controllers/pullsecret/pullsecret_controller_test.go
How do you know this will function as expected in production?
Running all unit tests locally and verifying their output
Is there any documentation that needs to be updated for this PR?
N/A