Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve OCP version definition in local RP #4006

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Tof1973
Copy link
Collaborator

@Tof1973 Tof1973 commented Dec 12, 2024

Which issue this PR addresses:

NA

What this PR does / why we need it:

When creating local RP, it was not obvious to create the OCP release.
Also, for DEV we do not need to specify the sha for the image, and this eases the add of a release in the DB.

So I propose this PR.

Test plan for issue:

NA

Is there any documentation that needs to be updated for this PR?

NA

How do you know this will function as expected in production?

NA

Copy link
Contributor

@hlipsig hlipsig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor grammatical changes. Looks great thanks!

docs/deploy-development-rp.md Outdated Show resolved Hide resolved
docs/deploy-development-rp.md Outdated Show resolved Hide resolved
docs/deploy-development-rp.md Outdated Show resolved Hide resolved
Tof1973 and others added 2 commits December 13, 2024 14:56
@Tof1973
Copy link
Collaborator Author

Tof1973 commented Dec 13, 2024

@hlipsig, thanks a lot for updates, should be OK now...

@Tof1973 Tof1973 requested a review from hlipsig December 13, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants