[ARO-12518] Map other error's http status codes to correct result type.

[pepedocs]

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-12518

What this PR does / why we need it:

NOTE: I have to recreate this PR from a direct branch of this repo as my previous PR from my fork was not picked up by azure CI (see
#3981)

What
Map other known backend errors returned by azure to their correct result type when logging them.

Why
Currently, these known errors are mapped to "InternalServerError" regardless of their nature (e.g. 5xx, 4xx) and logged as an InternalServerError. This breaks our CIF SLO reporting as it depends on parsing these logs.

Example UserErrors that are mapped to InternalServerError

network.SubnetsClient#CreateOrUpdate: Failure sending request: StatusCode=403 – Original Error: Code="LinkedAuthorizationFailed" Message= (backend)

ClientSecretCredential authentication failed. FromClientSecret(): http call(https://login.microsoftonline.com/xxx/oauth2/v2.0/token)(POST) error: reply status code was 400:

Test plan for issue:

Unit Test

• Ensure the following
  • ResponseError and DetailedError types' StatusCodes are utilized when mapping to error result type

Manual Test

• Mocked network.SubnetsClient#CreateOrUpdate: to use an invalid subnet so it will return a ResponseError and checked if it was logged as UserError.

Integration Tests

• Please suggest a method if you think it's necessary.

Is there any documentation that needs to be updated for this PR?

• None

How do you know this will function as expected in production?

• Tests were satisfied

[fahlmant]

@pepedocs Is this different than #3981 ?

[pepedocs]

@pepedocs Is this different than #3981 ?

@fahlmant The same changes, but I have to create this new PR from a direct branch (recommended) from this repo. The previous one was from my fork (which I'm used to), but azure CI does not anymore pick it up.

[edisonLcardenas]

/azp run ci

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[edisonLcardenas]

/azp run ci

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[edisonLcardenas]

/azp run ci

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[edisonLcardenas]

/azp run ci

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[pepedocs]

/azp run ci

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).