Fix Managed Identity Cluster creation dynamic validation flow #3891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajdeepc2792
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam,
bitoku and
fahlmant
as code owners
rajdeepc2792
added
ready-for-review
chainsaw
rajdeepc2792
force-pushed
the
rajdeepc2792/ARO-11049
branch
from
b992458 to
f27b233
Compare
kimorris27
requested changes
Oct 8, 2024
pkg/util/azureclient/azuresdk/armauthorization/roledefinitions.go
Outdated
Show resolved
Hide resolved
rajdeepc2792
force-pushed
the
rajdeepc2792/ARO-11049
branch
from
f27b233 to
1febcdd
Compare
|
Not making the change for this in the PR:- 82f41dc |
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kimorris27
approved these changes
Oct 10, 2024
tsatam
approved these changes
Oct 10, 2024
cadenmarchese
approved these changes
Oct 10, 2024
slawande2
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Fix Dynamic Validation Flow for Workload Identity * fix the mock msi object id export * Remove unwanted code * update OIDC_STORAGE_ACCOUNT_NAME local env setup * ARO-11049 resolve comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Jira - https://issues.redhat.com/browse/ARO-11049
Fixes the Managed Identity Cluster Creation flow until before the Federated Credential Creation
What this PR does / why we need it:
The PR resolves the bugs causing issues for the MIWI cluster creation during the dynamic validation flow.
Test plan for issue:
Updated Unit Test cases
Tested the local cluster creation flow till the federated identity creation
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
Tested in the local environment
e2e testing will be done for the flow after the feature is being tested.