Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK2: Replace SDK to new one in util/cluster #3884

Merged
merged 8 commits into from
Oct 4, 2024
Merged

Conversation

bitoku
Copy link
Collaborator

@bitoku bitoku commented Oct 4, 2024

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-4665

What this PR does / why we need it:

This replaces old SDK usages to the new one.
This is used for hack script to create a cluster and e2e cluster creation.

Test plan for issue:

ci, e2e

Is there any documentation that needs to be updated for this PR?

no

How do you know this will function as expected in production?

not a production feature.

Copy link
Collaborator

@tsatam tsatam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if we get passing E2E

@tsatam
Copy link
Collaborator

tsatam commented Oct 4, 2024

/azp run ci,e2e

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@tsatam tsatam merged commit 69378fb into master Oct 4, 2024
19 checks passed
@tsatam tsatam deleted the sdk2/util-cluster branch October 4, 2024 17:35
slawande2 pushed a commit that referenced this pull request Oct 7, 2024
* add subnets.List

* remove deprecated nsg & subnets client from util/cluster

* add routetable client

* remove deprecated route tables client from util/cluster

* add virtual network peerings client

* remove deprecated virtual network peerings from util/cluster

* remove the rest usage of mgmt network sdk

* remove unused sdk wrappers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants