Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove podman network causing outbound latency #3865

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

bennerv
Copy link
Collaborator

@bennerv bennerv commented Sep 25, 2024

Which issue this PR addresses:

Fixes a latency issue with outbound connections caused by the creation of dedicated podman networks.

What this PR does / why we need it:

Fix a regression in outbound connection latency.

Test plan for issue:

RP deploy

Is there any documentation that needs to be updated for this PR?

How do you know this will function as expected in production?

@bennerv bennerv force-pushed the bvesel/podman-network-hotfix branch from 15aea7f to 3a0e6bb Compare September 25, 2024 23:17
@bennerv
Copy link
Collaborator Author

bennerv commented Sep 25, 2024

untested as it requires a full-dev env.

@bennerv bennerv marked this pull request as draft September 25, 2024 23:37
@jaitaiwan
Copy link
Contributor

PR no longer needed. Closing out.

@jaitaiwan jaitaiwan closed this Sep 26, 2024
@bennerv bennerv reopened this Sep 26, 2024
@bennerv
Copy link
Collaborator Author

bennerv commented Sep 26, 2024

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bennerv
Copy link
Collaborator Author

bennerv commented Sep 26, 2024

e2e isn't testable by these scripts. Running CI but everything was good. Again these script changes are untested.

@bennerv bennerv marked this pull request as ready for review September 26, 2024 12:41
Copy link
Contributor

@SrinivasAtmakuri SrinivasAtmakuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SrinivasAtmakuri SrinivasAtmakuri added bug Something isn't working next-up ready-for-review release-blocker next-release To be included in the next RP release rollout labels Sep 26, 2024
@tsatam tsatam merged commit 7859644 into master Sep 26, 2024
35 checks passed
@bennerv bennerv deleted the bvesel/podman-network-hotfix branch September 26, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next-release To be included in the next RP release rollout next-up ready-for-review release-blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants