Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirrord blog post #4684

Merged
merged 7 commits into from
Jan 6, 2025
Merged

Mirrord blog post #4684

merged 7 commits into from
Jan 6, 2025

Conversation

qpetraroia
Copy link
Contributor

No description provided.

@qpetraroia qpetraroia requested review from palma21 and a team as code owners December 4, 2024 20:39
@qpetraroia qpetraroia requested a review from anson627 December 4, 2024 20:39
eyalb181
eyalb181 reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@eyalb181 eyalb181 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed some broken links

blog/_posts/2024-12-04-mirrord-on-aks.md Outdated Show resolved Hide resolved
gememma
gememma reviewed Dec 5, 2024
View reviewed changes
Copy link

@gememma gememma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! My only request is that mirrord-dev-loop.png be changed to a version with a lighter background so that the mirrord logo is still legible:

mirrord-dev-loop

@qpetraroia
Copy link
Contributor Author

@gememma, @eyalb181 - I have added the new picture. Please feel free to sign off if everything looks good. Thanks!

@eyalb181
Copy link
Contributor

eyalb181 commented Dec 6, 2024

@qpetraroia Looks great, approved from our end!

chzbrgr71
chzbrgr71 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@chzbrgr71 chzbrgr71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved.

eyalb181
eyalb181 reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@eyalb181 eyalb181 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

eyalb181
eyalb181 reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@eyalb181 eyalb181 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@qpetraroia qpetraroia merged commit 88a44d5 into Azure:master Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalb181 eyalb181 eyalb181 left review comments

@anson627 anson627 anson627 left review comments

@chzbrgr71 chzbrgr71 chzbrgr71 approved these changes

@palma21 palma21 palma21 approved these changes

@gememma gememma Awaiting requested review from gememma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qpetraroia @eyalb181 @anson627 @palma21 @chzbrgr71 @gememma