Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Private DNS Support #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Private DNS Support #43

wants to merge 2 commits into from

Conversation

jhisc
Copy link
Member

@jhisc jhisc commented Feb 10, 2022

Adding support for creating vnet linked Private DNS zones

Copy link
Member

@fabiendelpierre fabiendelpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't care a whole lot, but I'm wondering if it makes sense for this to be part of this module, or if it should be a separate module. Feels unrelated to a virtual network I guess?

main.tf Show resolved Hide resolved
@jhisc
Copy link
Member Author

jhisc commented Feb 10, 2022

I don't care a whole lot, but I'm wondering if it makes sense for this to be part of this module, or if it should be a separate module. Feels unrelated to a virtual network I guess?

Sadly this is going to be a standard part of vnet deployments moving forward.
Where an increasing number of DBaaS offerings are requiring us to create these zones. Given that they have a 1-2-1 relationship with Virtual Networks it seemed like an easier implementation for users if we put it in here.

@fabiendelpierre
Copy link
Member

Okay, I figured that would be your answer, so no worries then!

@jhisc
Copy link
Member Author

jhisc commented Feb 10, 2022

Thank you.
I'll hold off merging this in until @dutsmiller reviews. 2nd pair of eyes won't hurt

@jhisc jhisc changed the title Private DNS Support WIP: Private DNS Support Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants