Improve the k8s manifest and other minor details #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartou
commented
Apr 3, 2023
tonybaloney
reviewed
Apr 11, 2023
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Please remove the .vs/ folder from this PR
git rm -r .vs --cached or something similar would work
tonybaloney
reviewed
Apr 11, 2023
| @@ -0,0 +1,12 @@ | |||
| [[source]] | |||
There was a problem hiding this comment.
If the images aren't reading from this Pipfile, it can be removed
tonybaloney
reviewed
Apr 11, 2023
| @@ -1,3 +1,13 @@ | |||
| FROM tiangolo/uwsgi-nginx-flask:python3.6 | |||
There was a problem hiding this comment.
please remove the commented lines and the comment. The git history is sufficient to explain the change
tonybaloney
requested changes
Apr 11, 2023
| @@ -1,4 +1,7 @@ | |||
| FROM tiangolo/uwsgi-nginx-flask:python3.6 | |||
| # FROM tiangolo/uwsgi-nginx-flask:python3.6 | |||
There was a problem hiding this comment.
Please remove this from the branch and copy the contents into the PR description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use resource requests and limits for both azure-vote-back and azure-vote-front containers to ensure they have predictable resource usage and prevent resource starvation.
Set up liveness and readiness probes for both containers to improve the self-healing capabilities of your deployments and ensure the availability of your services.
Changes made
azure-vote-backandazure-vote-frontcontainers.beta.kubernetes.io/ostokubernetes.io/osas the beta label has been deprecated.