chore: remove noir-lang/ec dependency
#12507
Open
+46
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @kashbrti as related to nixing the ec library |
kashbrti
requested changes
Mar 6, 2025
noir-projects/noir-protocol-circuits/crates/types/src/address/aztec_address.nr
Show resolved
Hide resolved
| // as well as C3 = (C2 - 1)/2, where C2 = (p-1)/(2^c1), | ||
| // and C5 = ZETA^C2, where ZETA is a non-square element of Field. | ||
| // These are pre-computed above as globals. | ||
| pub(crate) fn sqrt(x: Field) -> Field { |
There was a problem hiding this comment.
Could you please add a fuzz test for the function?
we can just pick a field element x, square them, and check that the sqrt is +-x
There was a problem hiding this comment.
I think this can wait until we choose a final home for these functions. We're not losing any test coverage with this PR (pow and sqrt are completely untested inside of noir-lang/ec).
There was a problem hiding this comment.
as these are functions on the native field type, shouldn't they naturally be in stdlib?
| global C3: Field = 40770029410420498293352137776570907027550720424234931066070132305055; | ||
| global C5: Field = 19103219067921713944291392827692070036145651957329286315305642004821462161904; | ||
|
|
||
| pub(crate) fn pow(x: Field, y: Field) -> Field { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noir-lang/ecis a bad library and we're using it for non ec things. Let's take these non ec things out of the ec library and then not use the ec library.Maybe these non ec things can go into another place at some point... but today is not that day.