v2.4.18

Fixed scope bug introduced in v2.4.17
Aymkdn · Apr 18, 2023 · ec05571 · ec05571
1 parent 8a661cd
commit ec05571
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 8 deletions.
diff --git a/browser.js b/browser.js
diff --git a/docs/browser-2.4.17.js b/docs/browser-2.4.17.js
diff --git a/docs/browser-2.4.18.js b/docs/browser-2.4.18.js
diff --git a/docs/index.html b/docs/index.html
@@ -116,7 +116,7 @@ <h1>HTML to PDFMake convertor</h1>
       <div id="pdf_ie" style="display:none;padding:3em">The PDF file is sent to you for download. Use a modern browser (like Chrome or Firefox) to display the PDF in this page.</div>
     </div>
   </div>
-  <script src="browser-2.4.17.js"></script>
+  <script src="browser-2.4.18.js"></script>
   <script src="https://cdn.jsdelivr.net/npm/pdfmake@latest/build/pdfmake.min.js"></script>
   <script src="https://cdn.jsdelivr.net/npm/pdfmake@latest/build/vfs_fonts.js"></script>
   <script>

diff --git a/example.pdf b/example.pdf
diff --git a/index.js b/index.js
@@ -50,7 +50,7 @@ function htmlToPdfMake(htmlText, options) {
   this.ignoreStyles = (options && Array.isArray(options.ignoreStyles) ? options.ignoreStyles : []);
 
   // A random string to be used in the image references
-  this.imagesByReferenceSuffix = (Math.random().toString(36).slice(2,8));
+  var imagesByReferenceSuffix = (Math.random().toString(36).slice(2,8));
 
   // Used with the size attribute on the font elements to calculate relative font size
   this.fontSizes = (options && Array.isArray(options.fontSizes) ? options.fontSizes : [10, 14, 16, 18, 20, 24, 28]);
@@ -446,9 +446,9 @@ function htmlToPdfMake(htmlText, options) {
             if (this.imagesByReference) {
               var src = element.getAttribute("data-src") || element.getAttribute("src");
               var index = this.imagesRef.indexOf(src);
-              if (index>-1) ret.image = 'img_ref_'+this.imagesByReferenceSuffix+index;
+              if (index>-1) ret.image = 'img_ref_'+imagesByReferenceSuffix+index;
               else {
-                ret.image = 'img_ref_'+this.imagesByReferenceSuffix+this.imagesRef.length;
+                ret.image = 'img_ref_'+imagesByReferenceSuffix+this.imagesRef.length;
                 this.imagesRef.push(src);
               }
             } else {
@@ -942,7 +942,7 @@ function htmlToPdfMake(htmlText, options) {
     result = {content:result, images:{}};
     this.imagesRef.forEach(function(src, i) {
       // check if 'src' is a JSON string
-      result.images['img_ref_'+this.imagesByReferenceSuffix+i] = (src.startsWith("{") ? JSON.parse(src) : src);
+      result.images['img_ref_'+imagesByReferenceSuffix+i] = (src.startsWith("{") ? JSON.parse(src) : src);
     });
   }
   return result;

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "html-to-pdfmake",
-  "version": "2.4.17",
+  "version": "2.4.18",
   "description": "Convert HTML code to PDFMake",
   "main": "index.js",
   "scripts": {