Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder README types in constants for consistency #256

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kadiyam229
Copy link

Hey, I just made a Pull Request!

Updated the [README_TYPES] array to look for README.md first.

image

Context

The plugin does a call to bitbucket looking for each filename in its list for a README file. I think the list has five names, and README.md is last, so there are five requests to get a README file every time which is causing latency issue.

Issue ticket number and link

  • Fixes # (issue)

Checklist before requesting a review

  • [* ] I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have verified that my code follows the style already available in the repository
  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • [ *] Screenshots attached (for UI changes)

@kadiyam229 kadiyam229 requested a review from a team as a code owner March 4, 2025 23:50
@anicke
Copy link
Contributor

anicke commented Mar 5, 2025

Makes sense. I have created the related issue #258, hopefully that could be fixed soon.

@anicke
Copy link
Contributor

anicke commented Mar 5, 2025

Please add a changeset as well!

Copy link

changeset-bot bot commented Mar 5, 2025

⚠️ No Changeset found

Latest commit: 3601a22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kadiyam229
Copy link
Author

Makes sense. I have created the related issue #258, hopefully that could be fixed soon.

Simplified the config to decrease the number of lookups and reduce latency. Please check the updated PR

@kadiyam229
Copy link
Author

kadiyam229 commented Mar 5, 2025

Can someone hep me to understand the failure here

@anicke
Copy link
Contributor

anicke commented Mar 6, 2025

Have you tried to run "yarn prettier:fix"? That should fix it.

@kadiyam229
Copy link
Author

Have you tried to run "yarn prettier:fix"? That should fix it.

Thanks, how do I get this approved and merged?

@anicke
Copy link
Contributor

anicke commented Mar 7, 2025

You need to add the "backstage/config" package as a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants