Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleopatra DTL #8

Draft
wants to merge 47 commits into
base: develop
Choose a base branch
from
Draft

Cleopatra DTL #8

wants to merge 47 commits into from

Conversation

0xJem
Copy link
Collaborator

@0xJem 0xJem commented Jul 22, 2024

  • Adds a DTL contract for Cleopatra V1 (== Uniswap V2)
  • Adds a DTL contract for Cleopatra V2 (== Uniswap V3)
  • Make the BaseDTL contract more generalisable by having a virtual function called to transfer the pool token (instead of requiring an ERC20 to be returned by _mintAndDeposit()
  • Enable implementing BaseDTL contracts to disable linear vesting and validation checks
  • Add a check that _onSettle() has not already been called

@0xJem 0xJem self-assigned this Jul 22, 2024
Copy link
Contributor

@Oighty Oighty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, but needs a few changes.

@0xJem
Copy link
Collaborator Author

0xJem commented Jul 26, 2024

Note: support for the veRAM token ID was initially included for Ramses V2, but later removed due to an inability to decipher the Ramses voting contracts. In particular, it was reverting in the Voting.attachTokenToGauge() function.

@0xJem 0xJem changed the title Ramses/Cleo DTL Cleopatra DTL Jul 29, 2024
Base automatically changed from deploy-scripts to develop August 22, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants