Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add and fix testing to workflow #72

Draft
wants to merge 15 commits into
base: 4.1
Choose a base branch
from
Draft

Conversation

alamshafil
Copy link
Contributor

@alamshafil alamshafil commented Jul 13, 2022

This adds the option for GH Action to run our testing framework. Enabling the test runner will check if a breaking change such as wrong block reward or messed up diff algo is present and fail on GitHub.

Creating this PR as a draft to make sure all of our test pass and if not adapt to work with our code base.

Todo list:

Need to fix these tests for Avian:

  • SIGHASH_FORKID test
  • Script tests
  • RPC ban test
  • txvalidationcache tests
  • versionbits tests

@alamshafil alamshafil added the test QA testing system label Jul 13, 2022
@alamshafil
Copy link
Contributor Author

This PR is being blocked by #69 and needs to rebased against 4.1 once said PR is merged.

@alamshafil alamshafil force-pushed the 4.1-test-framework branch from fe82c45 to 53be46d Compare July 13, 2022 02:52
@alamshafil
Copy link
Contributor Author

This PR has been rebased against #69 allowing the use of a working regtest for testing.

@alamshafil alamshafil added the urgent Urgent fix that needs to be merged quickly label Jul 13, 2022
@alamshafil
Copy link
Contributor Author

This PR needs to rebased against 4.1 with PR #75 being merged.

@alamshafil alamshafil force-pushed the 4.1-test-framework branch from 53be46d to eeec031 Compare July 13, 2022 03:52
@alamshafil alamshafil changed the title ci: Add run test to workflow ci: Add and fix testing to workflow Jul 13, 2022
@alamshafil alamshafil removed the urgent Urgent fix that needs to be merged quickly label Jul 15, 2022
@alamshafil
Copy link
Contributor Author

Need to add proper SIGHASH_FORKID tests and fix nullptr secp256k1_context_sign.

@alamshafil alamshafil added this to the v4.1.0 milestone Aug 24, 2022
@alamshafil alamshafil mentioned this pull request Sep 12, 2022
23 tasks
@alamshafil alamshafil removed this from the v4.1.0 milestone Sep 16, 2022
@alamshafil
Copy link
Contributor Author

PR has been removed from 4.1 milestone, will be rebased against new version once branch is created.

@alamshafil alamshafil added this to the v4.2.0 milestone Oct 2, 2022
@alamshafil
Copy link
Contributor Author

Need to add dev fee testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test QA testing system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant