Merge pull request #181 from AvianNetwork/4.1

Merge 4.1 into master

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,40 @@
+---
+name: Bug Report
+about: Create a report to help us improve
+title: '[bug] '
+---
+
+<!-- Please make sure you are posting an technical issue related to Avian. --> 
+
+<!-- For general questions about Avian or wallet recovery please use one of the various communities:
+* [Reedit](https://www.reddit.com/r/aviannetwork/)
+* [Discord](https://discord.com/invite/avian) -->
+
+<!-- ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED! -->
+
+# Bug Report
+
+**Current behavior:**
+<!-- Describe how the bug manifests. -->
+
+**Expected behavior**
+<!-- Describe what the behavior would be without the bug. -->
+
+**Steps to reproduce:**
+<!--  Please explain the steps required to duplicate the issue, especially if you are able to provide a sample application or sample code -->
+
+**Screenshots**
+<!-- If the issue is related to the GUI, screenshots can be added to this issue via drag & drop. -->
+
+**Avian Core version**
+<!-- List the version number/commit ID, and if it is an official binary, self compiled or a distribution package such as PPA. -->
+
+**Machine specs**
+- OS:
+- CPU:
+- RAM:
+- Disk size:
+- Disk Type (HD/SDD):
+
+**Extra information**
+<!-- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,30 @@
+---
+name: Feature Request
+about: Suggest an idea for this project
+title: '[feat] '
+---
+
+<!-- Please make sure you are posting an technical issue related to Avian. --> 
+
+<!-- For general questions about Avian or wallet recovery please use one of the various communities:
+* [Reedit](https://www.reddit.com/r/aviannetwork/)
+* [Discord](https://discord.com/invite/avian) -->
+
+<!-- ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED! -->
+
+# Feature Request
+
+**Describe the Feature Request**
+<!-- A clear and concise description of what the feature request is. Please include if your feature request is related to a problem. -->
+
+**Describe Preferred Solution**
+<!-- A clear and concise description of what you want to happen. -->
+
+**Describe Alternatives**
+<!-- A clear and concise description of any alternative solutions or features you've considered. -->
+
+**Related Code**
+<!-- If you are able to illustrate the feature request with an example, please provide a samples via an online code collaborator such as [StackBlitz](https://stackblitz.com), or code snippet on [GitHub](https://github.com). -->
+
+**Additional Context**
+<!-- List any other information that is relevant to your issue. Stack traces, related issues, suggestions on how to add, use case, Stack Overflow links, forum links, screenshots, OS if applicable, etc. -->

.github/workflows/c-cpp.yml

@@ -36,27 +36,27 @@ jobs:
         include:
           - name: armhf-linux
             host: arm-linux-gnueabihf
-            os: ubuntu-18.04
+            os: ubuntu-20.04
             packages: g++-arm-linux-gnueabihf
             run-tests: false
             dep-opts: ""
-            config-opts: "--enable-gui=qt5 --enable-zmq --enable-glibc-back-compat --enable-reduce-exports CPPFLAGS=-DDEBUG_LOCKORDER"
+            config-opts: "--enable-gui=qt5 --enable-zmq --enable-glibc-back-compat --enable-reduce-exports"
             goal: install
           - name: aarch64-linux
             host: aarch64-linux-gnu
-            os: ubuntu-18.04
+            os: ubuntu-20.04
             packages: g++-aarch64-linux-gnu
             run-tests: false
             dep-opts: ""
-            config-opts: "--enable-gui=qt5 --enable-zmq --enable-glibc-back-compat --enable-reduce-exports CPPFLAGS=-DDEBUG_LOCKORDER"
+            config-opts: "--enable-gui=qt5 --enable-zmq --enable-glibc-back-compat --enable-reduce-exports"
             goal: install
           - name: x86_64-linux
             host: x86_64-unknown-linux-gnu
-            os: ubuntu-18.04
+            os: ubuntu-20.04
             packages: bc python3-zmq
             run-tests: false
             dep-opts: ""
-            config-opts: "--enable-gui=qt5 --enable-zmq --enable-glibc-back-compat --enable-reduce-exports CPPFLAGS=-DDEBUG_LOCKORDER"
+            config-opts: "--enable-gui=qt5 --enable-zmq --enable-glibc-back-compat --enable-reduce-exports"
             goal: install
             strip-cmd: "strip"
           - name: x86_64-win
@@ -70,7 +70,7 @@ jobs:
               sudo update-binfmts --import /usr/share/binfmts/wine
             run-tests: false
             dep-opts: ""
-            config-opts: "--enable-reduce-exports --enable-gui=qt5"
+            config-opts: "--disable-shared --enable-gui=qt5"
             goal: install
             strip-cmd: "x86_64-w64-mingw32-strip"
           - name: x86_64-macos

.github/workflows/codeql-analysis.yml

@@ -0,0 +1,69 @@
+# CodeQL GH Actions file for Avian Core
+name: CodeQL
+
+on:
+  push:
+    paths-ignore:
+      - '**/*.md'
+      - '**/*.txt'
+      - 'contrib'
+      - 'doc'
+      - 'share'
+      - 'test'
+  pull_request:
+    paths-ignore:
+      - '**/*.md'
+      - '**/*.txt'
+      - 'contrib'
+      - 'doc'
+      - 'share'
+      - 'test'
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-18.04
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'cpp' ]
+        # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v2
+
+    - name: Update system
+      run: |
+        sudo apt-get update --yes
+        sudo apt-get install build-essential libtool autotools-dev automake pkg-config bsdmainutils --yes
+    - name: Dependency cache
+      uses: actions/cache@v2
+      env:
+        cache-name: depends
+      with:
+        path: ./depends/built
+        key: codeql-${{ env.cache-name }}-${{ hashFiles('depends/packages/*') }}
+
+    - name: Build depends
+      run: |
+        pushd depends
+        make -j4 HOST=x86_64-pc-linux-gnu
+        popd
+    - name: Initialize CodeQL
+      uses: github/codeql-action/init@v2
+      with:
+        languages: ${{ matrix.language }}
+
+    - name: Build Avian Core
+      run: |
+       ./autogen.sh
+       ./configure --prefix=`pwd`/depends/x86_64-pc-linux-gnu
+       make -j4
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@v2

.gitignore

@@ -42,7 +42,7 @@ src/config/stamp-h1
 share/setup.nsi
 share/qt/Info.plist
 src/config/avian-config.h
-
+src/config/avian-config.h.in
 
 src/qt/*.moc
 src/qt/moc_*.cpp
@@ -124,3 +124,13 @@ contrib/devtools/split-debug.sh
 cmake-build-debug
 
 CMakeLists.txt
+
+# qtcreator
+.qtc_clangd
+Avian.cflags
+Avian.config
+Avian.creator
+Avian.cxxflags
+Avian.files
+Avian.includes
+Avian.creator.user

COPYING

@@ -2,7 +2,7 @@ The MIT License (MIT)
 
 Copyright (c) 2009-2018 The Bitcoin Core developers
 Copyright (c) 2018 The Raven Core developers
-Copyright (c) 2022 The Raven Core developers
+Copyright (c) 2022 The Avian Core developers
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal