Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for segment anything model #262

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

lukiod
Copy link
Contributor

@lukiod lukiod commented Jan 12, 2025

Closes:

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made
Added point , Box and Segment Everything Support Text will not work on it as segment anything doesnt support text still added text label so as it will be easier for future implementation

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Working Video 📷

image
image

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@lukiod
Copy link
Contributor Author

lukiod commented Jan 13, 2025

@Avdhesh-Varshney could u review and merge this

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide a working video of your model with Jarvis.

@lukiod
Copy link
Contributor Author

lukiod commented Jan 13, 2025

Buddy I am on linux I can't record a vedio my obs is brocken so that's why I added a screenshot > Provide a working video of your model with Jarvis.

requirements.txt Outdated Show resolved Hide resolved
@Avdhesh-Varshney Avdhesh-Varshney added question❓ Further information is requested Status: Review Ongoing and removed bug Something isn't working Status: Requested Changes labels Jan 13, 2025
Copy link
Collaborator

@jindalpriyanshu101 jindalpriyanshu101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in requirements.txt aren't required as we're utilising transformer v4.45.2.

Therefore, discard the changes in requirements.txt and re-evaluate your Segments model with transformer v4.45.2

@jindalpriyanshu101
Copy link
Collaborator

@lukiod Have you re-evaluated the model with transformer v4.45.2? Can you attach some screenshots/videos to show the performance?

@lukiod
Copy link
Contributor Author

lukiod commented Jan 14, 2025

@jindalpriyanshu101 here is the ss
image

Copy link
Collaborator

@jindalpriyanshu101 jindalpriyanshu101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Approved.

Nice work ;D

@jindalpriyanshu101 jindalpriyanshu101 merged commit 219a006 into Avdhesh-Varshney:main Jan 14, 2025
@jindalpriyanshu101 jindalpriyanshu101 added ADVANCE and removed question❓ Further information is requested Status: Review Ongoing labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📃: Segment anything on images.
3 participants