Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scientific Calculator #81 #255

Closed
wants to merge 1 commit into from

Conversation

fah-04
Copy link

@fah-04 fah-04 commented Jan 9, 2025

Closes: #81

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made
I have created a scientific calculator with all the required and also deployed it.

Checklist: ☑️

  • [ x] My code follows the Contributing Guidelines & Code of Conduct of this project.
  • [ x] This PR does not contain plagiarized content.
  • [ x] I have performed a self-review of my own code.
  • [ x] I have commented my code, particularly wherever it was hard to understand.
  • [ x] My changes generate no new warnings.

Working Video 📷

Screenshot 2025-01-09 131608
my system doesn't support video here's a screenshot

Copy link

github-actions bot commented Jan 9, 2025

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@jindalpriyanshu101
Copy link
Collaborator

jindalpriyanshu101 commented Jan 9, 2025

What the what?? 💀 4k Lines of code?

Copy link
Collaborator

@jindalpriyanshu101 jindalpriyanshu101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fah-04 You were supposed to implement this calculator in Jarvis using streamlit while following the project Guidelines....

What made you to create a PR with HTML?

@fah-04
Copy link
Author

fah-04 commented Jan 9, 2025

ouch, my bad i did not understand the repo
can i create it a nav sidebar for the new tab or in what format can i implement it into the jarvis AI?
or u can unassign me😭👍

@jindalpriyanshu101
Copy link
Collaborator

No worries, if you want to you can restart working on it by simply having to write it using Python, and place it under appropriate folder, src/apps/pages/programs/--here-- You can also checkout How other files were made.

Make sure you're writing that using streamlit, and its compatible with current implementation. @fah-04 i'll advice you to go through contribution guide.

Do let me know if you wanna rework on this issue. This PR is discarded anyways.

@jindalpriyanshu101
Copy link
Collaborator

Discarded.

@fah-04 fah-04 deleted the scifi-calculator branch January 10, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📃: Scientific Calculator
2 participants