-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Selector Height for Radio/Check Mode #2425
Fix Selector Height for Radio/Check Mode #2425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
For homogeneity sake, I would have used double quotes for all string literals though.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better return undefined than {}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done, tx @Satoshi-Sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What type of PR is this? (check all applicable)
Description
The height property doesn't work on Radio and Check mode. I updated the Selector component and added styling with sx. I added a unit test for that.
Related Tickets & Documents
How to reproduce the issue
The height of the selector doesn't work on the Radio and Check mode.
After fix:
Checklist
We encourage you to keep the code coverage percentage at 80% and above.