Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong link to download my_config.py file #799

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Wrong link to download my_config.py file #799

merged 2 commits into from
Jan 23, 2024

Conversation

trgiangdo
Copy link
Member

@trgiangdo trgiangdo commented Jan 23, 2024 •
edited by FabienLelaquais
Loading

Resolves #745.

@FabienLelaquais FabienLelaquais changed the title Fix/#745 - Wrong link to download my_config.py file Wrong link to download my_config.py file Jan 23, 2024
@FabienLelaquais FabienLelaquais added the 📄 Documentation Internal or public documentation label Jan 23, 2024
FabienLelaquais
FabienLelaquais approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/manuals/core/entities/data-node-mgt.md Outdated Show resolved Hide resolved
docs/manuals/core/entities/data-node-mgt.md Outdated Show resolved Hide resolved
docs/manuals/core/entities/data-node-mgt.md Outdated Show resolved Hide resolved
docs/manuals/core/entities/data-node-mgt.md Outdated Show resolved Hide resolved
docs/manuals/core/entities/data-node-mgt.md Outdated Show resolved Hide resolved
@trgiangdo @FabienLelaquais
Apply suggestions from code review
24b9ddd 
Co-authored-by: Fabien Lelaquais <[email protected]>
@trgiangdo trgiangdo merged commit a9556b0 into develop Jan 23, 2024
1 check passed
@trgiangdo trgiangdo deleted the fix/#745-wrong-link-to-download-config-file branch January 23, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabienLelaquais FabienLelaquais FabienLelaquais approved these changes

Assignees

@trgiangdo trgiangdo

Labels
📄 Documentation Internal or public documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG-no my-config file provided for Data node management Tutorial
2 participants
@trgiangdo @FabienLelaquais