Added Code Sample and manual for S3 Object DataNode #785
Conversation
There was a problem hiding this comment.
Thank you @Forchapeatl. I have some small comments, and concerning the configuration example.
| if __name__ == "__main__": | ||
|
|
||
| Core().run() | ||
| scenario = tp.create_scenario(scenario_cfg) | ||
| Gui(page).run(debug=True) |
There was a problem hiding this comment.
The example should be minimal, which means only containing the configuration.
You can add an example on how to read/write S3ObjectDataNode on the docs/manuals/core/entities/data-node-mgt.md page.
There was a problem hiding this comment.
I agree.
- I believe there is no need to run any Gui here.
- I believe we don't need to configure a scenario here.
- We can just configure a Global s3 data node using
Config.configure_s3_data_node(...). - We can instantiate the data node using
taipy.create_global_data_node(...) - We can explain how to write data and how to read data using
datanode.write(...)anddatanode.read()
- We can just configure a Global s3 data node using
docs/manuals/core/config/code_example/data_node_cfg/data-node-config-aws-s3.py
Outdated
Show resolved
Hide resolved
docs/manuals/core/config/code_example/data_node_cfg/data-node-config-aws-s3.py
Outdated
Show resolved
Hide resolved
|
@Forchapeatl Thank you once again for your contribution. We highly appreciate your work and eagerly collaborating with you on this PR. If you could provide an update or let us know if you need more time to answer the unresolved Comments, that would be greatly appreciated. |
I just need more time . Please I will work on this before this week ends. |
|
Hello @trgiangdo and @jrobinAV , thank you for the reviews . The requested changes have been made. |
docs/manuals/core/config/code_example/data_node_cfg/data-node-config-aws-s3.py
Outdated
Show resolved
Hide resolved
Part of Avaiga/taipy#536