Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add investment screening user management enterprise tutorial #1262

Merged

Conversation

arcanaxion
Copy link
Contributor

@arcanaxion arcanaxion commented Jan 21, 2025

Checklist before merge:

  • Make demo site live
  • Fix hyperlink references to pkg_enterprise and pkg_auth

@AlexandreSajus @FlorianJacta Requesting your feedback on the following:

  1. I placed this under tutorials/fundamentals, because it seemed the most appropriate (this is fundamental taipy enterprise). But I used the gallery enterprise banner, rather than the databricks enterprise banner, because it seemed the most appropriate (see screenshot). Is this ok?
  2. Do we want to make the repo public? I think we should, but we do need to wait for the next release because 4.0.2-enterprise still has the AuthorizedPage scope issue.
  3. I bumped the version of Markdown because it was holding back pymdown-extensions to 10.4, and I wanted to use image captions. Is this ok?

Screenshots:

user_management_screenshot

User Management in Taipy Enterprise - Taipy.zip

mkdocs.yml_template Outdated Show resolved Hide resolved
@arcanaxion
Copy link
Contributor Author

@FlorianJacta @AlexandreSajus Demo site is live. I can't fully build the docs without access to the enterprise repo, so appreciate your help with letting me know how to adjust the following links:

  1. https://docs.taipy.io/en/latest/refmans/reference/pkg_taipy/pkg_enterprise/pkg_gui/AuthorizedPage/
  2. https://docs.taipy.io/en/latest/refmans/reference/pkg_taipy/pkg_auth/Credentials/
  3. https://docs.taipy.io/en/latest/refmans/reference/pkg_taipy/pkg_auth/Authorize
  4. https://docs.taipy.io/en/latest/refmans/reference/pkg_taipy/pkg_auth/login/
  5. https://docs.taipy.io/en/latest/refmans/reference/pkg_taipy/pkg_enterprise/pkg_gui/login/
  6. https://docs.taipy.io/en/latest/refmans/reference/pkg_taipy/pkg_enterprise/pkg_gui/get_credentials/

Can I simply reference the classes like AuthorizedPage, Credentials and Authorize with, e.g., `Credentials^`?

Then for 4-6, I will ofc replace https://docs.taipy.io/en/latest/ with ../../../ but I'm not clear on which end with <name>/index.md vs. <name>.md.

@FlorianJacta
Copy link
Member

When you do not put the right login, what is the behavior of the login page? I have that it freezes

@arcanaxion
Copy link
Contributor Author

When you do not put the right login, what is the behavior of the login page? I have that it freezes

Ah, I'm getting the same issue on the deployed app. on_login calls tp.enterprise.gui.login which should throw an exception with the wrong login and on_exception will handle_logout. This works correctly on localhost -- upon clicking "log in" with invalid creds, you're notified and redirected to the main page practically instantly. Any ideas?

@FlorianJacta
Copy link
Member

Did you try it on Docker locally as well?

@FlorianJacta
Copy link
Member

The doc section about http://127.0.0.1:8000/en/develop/userman/advanced_features/auth/ is broken for me. I don't know what's going on. I'll investigate

@FlorianJacta
Copy link
Member

I have pushed changes about relative paths to your PR.

Also, Markdown lines should not exceed 100 characters

@arcanaxion
Copy link
Contributor Author

Did you try it on Docker locally as well?

Good point. Let me try with the changes FV made.

I have pushed changes about relative paths to your PR.

This seems to have broken it for me. Could it be because I'm missing the content referenced (i.e. the enterprise/auth packages)? This is the start of the new output:

image

Also, Markdown lines should not exceed 100 characters

Alright, I'll do this last

@arcanaxion
Copy link
Contributor Author

@FlorianJacta There's no special changes other than the way that taipy-enterprise is installed. I hosted it on Docker and it worked fine. Also, the aforementioned behaviour is currently not happening on https://investment-screening.taipy.cloud/. If it recurs, I guess maybe it needs a larger VM

@FlorianJacta
Copy link
Member

This seems to have broken it for me. Could it be because I'm missing the content referenced (i.e. the enterprise/auth packages)? This is the start of the new output:

I had this kind of page when I didn't fetch all the packages carefully (Enterprise included). This is annoying. @jrobinAV or @FabienLelaquais have you got this issue? How can this be fixed?

@FlorianJacta
Copy link
Member

FlorianJacta commented Jan 28, 2025

I also have the appropriate behavior in my Docker locally. I guess the next step is to try to log what happens behind or wait for @florian-vuillemot for some info

@FlorianJacta
Copy link
Member

What is the status of this PR?

@arcanaxion
Copy link
Contributor Author

@FlorianJacta Is the reference to enterprise/auth issue only affecting local builds? If it's working fine in the workflow then I'll change the line lengths to 100 and it's ready to review. Let me know

@arcanaxion arcanaxion marked this pull request as ready for review February 3, 2025 03:39
@FlorianJacta
Copy link
Member

@arcanaxion Everything is fine for me! Can this be merged then?

@arcanaxion
Copy link
Contributor Author

@FlorianJacta Yup, can be merged. Regarding the issue with building the page with enterprise/auth references, this is unintended right? If so, could you open an issue for this since you understand it better than I do

@FlorianJacta FlorianJacta merged commit 8eb02d4 into Avaiga:develop Feb 3, 2025
1 check passed
@FlorianJacta
Copy link
Member

#1272

@FlorianJacta
Copy link
Member

Let's wait for the build on develop to be online and if everything is fine, we can then merge this PR to 4.0 too.

FlorianJacta added a commit that referenced this pull request Feb 3, 2025
Add investment screening user management enterprise tutorial
FlorianJacta added a commit that referenced this pull request Feb 4, 2025
Merge pull request #1262 from arcanaxion/add-user-management-tutorial
@arcanaxion arcanaxion deleted the add-user-management-tutorial branch February 5, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants