-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamping the "Understanding GUI" tutorial #1232
Conversation
} | ||
``` | ||
|
||
This will add a margin to the top of the button to align it with the filters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will be now resolved in develop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this done with develop?
.reset_index() | ||
) | ||
|
||
layout = {"yaxis": {"title": "Revenue (USD)"}, "title": "Sales by State"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these properties are already exposed yaxis and title. We should use them. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I'm pushing a commit for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, yaxis and title do not seem to work. I'm creating an issue on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this tutorial as this is easy and straight to the point. I like it. It is missing from Understand Gui some info but I don't how important it is:
The tutorial should also be proposed in Markdown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job though!
type="bar", | ||
layout="{layout}", | ||
) | ||
tgb.chart(figure="{map_fig}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said hundreds of times.
It is a bad idea to rely on figures. That does not provide the data management capabilities of Taipy GUI, and breaks the added value compared to competitors.
If things need to be improved on the chart side, please let R&D know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example I give is relevant: the map I create is really difficult to create using Taipy charts so I use a Plotly one. I used Taipy charts for the other charts.
We need to introduce this feature to prove that it is easy to create good looking charts using figure=
. If you want I can put a disclaimer that this is not the optimal way to create charts.
lov="{subcategories}", | ||
dropdown=True, | ||
) | ||
with tgb.part(class_name="text-center"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need a part if there's only one element?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parts are a good way to visually separate in the code the contents of different columns. Also here I use part to center the button horizontally. Is there another way to center the button without using part nor CSS?
Let's now add a new container for the filters: | ||
|
||
```python | ||
with tgb.part(class_name="card"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a part if there's only a block?
Why all those parts all over the place??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parts are a good way to visually separate in the code the contents of different parts of the app
mkdocs.yml_template
Outdated
@@ -30,6 +30,12 @@ nav: | |||
- "5 - Python expressions in properties": tutorials/articles/understanding_gui/step_05/step_05.md | |||
- "6 - Page layouts": tutorials/articles/understanding_gui/step_06/step_06.md | |||
- "7 - Multi-pages, navbars, and menus": tutorials/articles/understanding_gui/step_07/step_07.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the purpose was to replace the "Understanding GUI" tutorial. Here you just added a new one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was not sure if you guys would agree to replace the "Understanding GUI" tutorial so for the time I put it separately. When I'm done with the requested changes and if everyone agrees, this tutorial will replace "Understanding GUI"
Note: I should deploy this application so that people can try the application before even doing the tutorial |
I have implemented most of the requested changes, and the PR is now ready to be merged. Please review it again and let me know if additional changes need to be made. |
Co-authored-by: Jean-Robin <[email protected]>
Co-authored-by: Jean-Robin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫤
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Revamping the "Understanding GUI" tutorial
This is a work in progress:
This tutorial intends to replace the "Understanding GUI" tutorial and should be the first tutorial users follow after the "Getting Started".
The tutorial worked well when training new customers, so it would be appropriate to include it in the docs. It creates a simple sales dashboard by focusing on visual elements, styling, charts, and multiple pages.
The tutorial is also available in video format on YouTube