Allows float values for gallery article order #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreSajus
added
📈 Improvement
|
Did you build the doc with this too? |
|
Yes, and it works. I added a demo in #1194 with |
|
Lovely! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, articles in the gallery are sorted according to an integer value in the header of the article:
Since the values are integers, adding an article between two articles forces contributors to modify the order value of many articles: if I want to place an article at position 6, I must take all articles from position 6 to N and increment their order by 1.
By accepting float values for order, we allow contributors to place an article at position 6 by setting the order at 6.5