Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed documentation for dialog #1147

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Conversation

FabienLelaquais
Copy link
Member

@FabienLelaquais FabienLelaquais commented Oct 3, 2024

Addresses #1115 and #1148.

Renamed all references to code examples

Renamed all references to code examples
@FabienLelaquais FabienLelaquais added 🖰 GUI Related to GUI 📄 Documentation Internal or public documentation 💥Malfunction Addresses an identified problem. 🟧 Priority: High Stalls work on the project or its dependents labels Oct 3, 2024
@FabienLelaquais FabienLelaquais self-assigned this Oct 3, 2024
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose I'm wrong about taipy-date_range but it looks really weird... I suppose for 5.0 :-)
Well done
Quite a job

Copy link
Member

@namnguyen20999 namnguyen20999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_ => - in class names

@FredLL-Avaiga FredLL-Avaiga self-requested a review October 4, 2024 09:30
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FabienLelaquais FabienLelaquais merged commit dd80b9d into develop Oct 4, 2024
1 check passed
@FabienLelaquais FabienLelaquais deleted the doc/#1115-dialog-doc branch October 4, 2024 09:45
jrobinAV pushed a commit that referenced this pull request Oct 4, 2024
* Fixed documentation for dialog
* Renamed all references to code examples
* More RelNotes
* Added links to date_range code examples
* Added styling example for date_range
* Fred's comment.
jrobinAV added a commit that referenced this pull request Oct 4, 2024
* Cleaning code using object programming

* extract reader

* merge develop

* Better document why we need to handle config.

* improve doc generation

* Config doc

* UX

* Update config handler regarding attribute documentation

* Xrefs

* Xrefs and minor improvements

* re adding taipy as prefix

* re adding taipy as prefix

* Handle taipy.common

* Update taipy_theme/assets/stylesheets/avaiga.css

Co-authored-by: Fabien Lelaquais <[email protected]>

* Update taipy_theme/assets/stylesheets/avaiga.css

Co-authored-by: Fabien Lelaquais <[email protected]>

* Test for proper retrieval of Designer (#1143)

* Document the new predefined edition behavior in tables (#1133)

* Add and update docs for table and selector
* Mention Polars support
* Added doc for style parameter of Page classes
* Added dynamic styling example
* Release Notes update
* Added note on Lambdas as property values
* Enumerated classes as candidates for *lov*

* Add run command section (#1144)

* Add run command section

* Add a line break

* Remove $ in the command

* Fixed documentation for dialog (#1147)

* Fixed documentation for dialog
* Renamed all references to code examples
* More RelNotes
* Added links to date_range code examples
* Added styling example for date_range
* Fred's comment.

* Fabien's comments

* PipFile

---------

Co-authored-by: Fabien Lelaquais <[email protected]>
Co-authored-by: Satoshi S. <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 Documentation Internal or public documentation 🖰 GUI Related to GUI 💥Malfunction Addresses an identified problem. 🟧 Priority: High Stalls work on the project or its dependents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants