Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples and images to the text control's doc #1049

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Add examples and images to the text control's doc #1049

merged 2 commits into from
Jul 24, 2024

Conversation

FabienLelaquais
Copy link
Member

Fixes #973

@FabienLelaquais FabienLelaquais added 📈 Improvement Improvement of a feature. 🖰 GUI Related to GUI 📄 Documentation Internal or public documentation 🟧 Priority: High Stalls work on the project or its dependents labels Jul 24, 2024
@FabienLelaquais FabienLelaquais self-assigned this Jul 24, 2024
AlexandreSajus
AlexandreSajus reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@AlexandreSajus AlexandreSajus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good examples! This will make the text visual element much more accessible.

A link does not render but might be an mkdocs issue on my end. Please check:
image

AlexandreSajus
AlexandreSajus approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@AlexandreSajus AlexandreSajus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@FabienLelaquais FabienLelaquais merged commit ef93b5f into develop Jul 24, 2024
1 check passed
@FabienLelaquais FabienLelaquais deleted the doc/#973-text-control-examples branch July 24, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreSajus AlexandreSajus AlexandreSajus approved these changes

@FredLL-Avaiga FredLL-Avaiga FredLL-Avaiga approved these changes

Assignees

@FabienLelaquais FabienLelaquais

Labels
📄 Documentation Internal or public documentation 🖰 GUI Related to GUI 📈 Improvement Improvement of a feature. 🟧 Priority: High Stalls work on the project or its dependents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] More examples around mode for text control
3 participants
@FabienLelaquais @AlexandreSajus @FredLL-Avaiga