-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commodity trading application #1025
Add commodity trading application #1025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a prominent disclaimer that the data behind the app has been mocked, so interacting with the app does nothing. We don't want people trying out the app and thinking Taipy is buggy because nothing happens when changing the date.
Third in the finance category is a good position
@AlexandreSajus I didn't know it changed nothing. I think this is bad... We should create fake data and have the interactions working. What do you think? |
It's your call, it's a lot of fake data to generate so we could generate it randomly. Or we could just explain that there is no interaction because this is a mock application. |
An "Enterprise" application shouldn't be in this state. |
Blocked by creating interaction in application. |
What do you think of it now? https://commodity-trading.taipy.cloud/ |
It is an improvement, but some pages still don't have interaction like this one: |
Zacch didn't bring interactivity to these pages: https://github.com/Avaiga/demo-commodity-trading/pull/9 They should come later. I propose to make their buttons/date inactive. |
This is done. Viz elements are inactive if they don't bring interactivity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, looks good to me!
…application Add commodity trading application
Resolves #1024
The application has been deployed: https://commodity-trading.taipy.cloud/
The repository has been created:
Question: What should be the position of the application?
Commodity Trading - Taipy (2).zip