Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commodity trading application #1025

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

FlorianJacta
Copy link
Member

@FlorianJacta FlorianJacta commented Jul 1, 2024

Resolves #1024

The application has been deployed: https://commodity-trading.taipy.cloud/

The repository has been created:

Question: What should be the position of the application?

image

image

image

image

Commodity Trading - Taipy (2).zip

@FlorianJacta FlorianJacta added 📈 Improvement Improvement of a feature. 📄 Documentation Internal or public documentation 🟧 Priority: High Stalls work on the project or its dependents labels Jul 1, 2024
@FlorianJacta FlorianJacta self-assigned this Jul 1, 2024
Copy link
Contributor

@AlexandreSajus AlexandreSajus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a prominent disclaimer that the data behind the app has been mocked, so interacting with the app does nothing. We don't want people trying out the app and thinking Taipy is buggy because nothing happens when changing the date.

Third in the finance category is a good position

@FlorianJacta
Copy link
Member Author

@AlexandreSajus I didn't know it changed nothing. I think this is bad... We should create fake data and have the interactions working. What do you think?

@FlorianJacta FlorianJacta marked this pull request as draft July 1, 2024 14:44
@AlexandreSajus
Copy link
Contributor

It's your call, it's a lot of fake data to generate so we could generate it randomly. Or we could just explain that there is no interaction because this is a mock application.

@FlorianJacta
Copy link
Member Author

An "Enterprise" application shouldn't be in this state.

@FlorianJacta FlorianJacta added the ❌ Blocked Issue is blocked label Jul 10, 2024
@FlorianJacta
Copy link
Member Author

Blocked by creating interaction in application.

@FlorianJacta FlorianJacta marked this pull request as ready for review July 11, 2024 07:12
@FlorianJacta
Copy link
Member Author

What do you think of it now? https://commodity-trading.taipy.cloud/
@AlexandreSajus

@AlexandreSajus
Copy link
Contributor

It is an improvement, but some pages still don't have interaction like this one:
https://commodity-trading.taipy.cloud/group_contributions
Is this intended?

@FlorianJacta
Copy link
Member Author

FlorianJacta commented Jul 18, 2024

Zacch didn't bring interactivity to these pages: https://github.com/Avaiga/demo-commodity-trading/pull/9

They should come later. I propose to make their buttons/date inactive.

@FlorianJacta
Copy link
Member Author

This is done. Viz elements are inactive if they don't bring interactivity.

@AlexandreSajus AlexandreSajus self-requested a review July 18, 2024 09:07
Copy link
Contributor

@AlexandreSajus AlexandreSajus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, looks good to me!

@FlorianJacta FlorianJacta merged commit 8e32b7a into develop Jul 19, 2024
1 check passed
@FlorianJacta FlorianJacta deleted the doc/#1024-add-commodity-trading-application branch July 19, 2024 08:12
FlorianJacta added a commit that referenced this pull request Jul 19, 2024
…application

Add commodity trading application
FlorianJacta added a commit that referenced this pull request Jul 22, 2024
Merge pull request #1025 from Avaiga/doc/#1024-add-commodity-trading-…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❌ Blocked Issue is blocked 📄 Documentation Internal or public documentation 📈 Improvement Improvement of a feature. 🟧 Priority: High Stalls work on the project or its dependents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add commodity trading application to Gallery
2 participants