Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain Transfer: Annotate flow with deprecated version to fix type error #98862

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

zaguiini
Copy link
Contributor

Related to #95634 and #97999.

Proposed Changes

We were using a method called useSteps in a "v1" flow, however the type annotation indicated that the flow might be v1 or v2, which doesn't include this method. Because of it, we were getting a type error and failing CI.

@zaguiini zaguiini self-assigned this Jan 24, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 24, 2025
@zaguiini zaguiini changed the title Domain Transfer: Annotate flow with deprecated type version to fix type error Domain Transfer: Annotate flow with deprecated version to fix type error Jan 24, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@zaguiini zaguiini merged commit b166d2f into trunk Jan 24, 2025
15 of 18 checks passed
@zaguiini zaguiini deleted the fix-100-years-domain-type branch January 24, 2025 00:13
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants