Reader: Stop showing daily prompt modal on editor screen

[mehmoodak]

Related to https://github.com/Automattic/loop/issues/326

Proposed Changes

Remove new_prompt query param from the url which will stop showing daily prompt modal on editor screen.

Why are these changes being made?

Removed in favour of showing inline placeholder text.

Testing Instructions

• Go to https://wordpress.com/post/mehmoodak2.wordpress.com?new_prompt=true and verify modal is appearing.
• Pull this PR locally or use calypso live link.
• Go to calypso.localhost:3000/post/mehmoodak2.wordpress.com?new_prompt=true and verify modal is not appearing.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130642

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130642&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130642&env=a8c-for-agencies

[mehmoodak]

We reverted the earlier PR (#98473) due to the failing of e2e tests so in this PR we have fixed the broken tests.

Since there is no code change from last PR so will merge this PR without getting further approval.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug reader/stop-showing-daily-prompt-modal-again on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~34 bytes removed 📉 [gzipped])

name                parsed_size           gzip_size
site-setup-wg             -34 B  (-0.0%)      -16 B  (-0.0%)
site-setup-flow           -34 B  (-0.0%)      -16 B  (-0.0%)
start-writing-flow        -32 B  (-0.1%)       -9 B  (-0.1%)
gutenberg-editor          -29 B  (-0.0%)       -9 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.