Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WooCommerce Installer: Further cleanup #98740

Merged
merged 1 commit into from
Jan 23, 2025
Merged

WooCommerce Installer: Further cleanup #98740

merged 1 commit into from
Jan 23, 2025

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Jan 22, 2025

Proposed Changes

Further cleanup the Woo installer that was introduced in #58179.

Continues the cleanup work from #60784.

We're basically removing a couple more components and a feature flag.

Why are these changes being made?

Just cleaning up.

Testing Instructions

  • Verify the removed code is not in use.
  • All checks should be green.

@tyxla tyxla added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial WooCommerce Woop WooCommerce on Plans Pod labels Jan 22, 2025
@tyxla tyxla requested review from lsl, allilevine and a team January 22, 2025 13:58
@tyxla tyxla self-assigned this Jan 22, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug cleanup/woop-installer on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tyxla tyxla merged commit 8720994 into trunk Jan 23, 2025
18 checks passed
@tyxla tyxla deleted the cleanup/woop-installer branch January 23, 2025 06:50
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants