Server Settings: Fix warning in SFTP users

[tyxla]

Proposed Changes

Simplify the code to retrieve SFTP users. Currently, it creates a new object inside a useSelector(), triggering a bunch of additional rerenders. Instead, we can derive the state and avoid those rerenders.

Why are these changes being made?

To reduce rerenders and remove this warning:

Testing Instructions

• Go to /hosting-config/:site where :site is one of your Atomic sites.
• Verify the warning doesn't appear anymore.

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130268

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130268&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130268&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/sftp-form-users-warning on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~14 bytes removed 📉 [gzipped])

name          parsed_size           gzip_size
staging-site        -55 B  (-0.0%)      -14 B  (-0.0%)
site-tools          -55 B  (-0.0%)      -14 B  (-0.0%)
hosting             -55 B  (-0.0%)      -14 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[ciampo]

LGTM 🚀

I created an atomic site and confirmed that the warning is gone.

[ciampo]

As a follow-up, we could improve the logic in this file, since it currently doesn't take into account the possibility that username is not defined.

I suggest adding some checks and return a fallback UI while they are not defined.

[tyxla]

It's all under a username && check already, I believe that should be enough:

wp-calypso/client/sites/tools/sftp-ssh/sftp-form.tsx

Line 340 in f74022a

{ username && (

Or are you referring to something else?

[ciampo]

The JSX is, but that doesn't mean guarantee TypeScript that username in the highlighted line is defined. It's at best an implicit typecase, at at worst a possible edge-case runtime error.