Remove loading state from CheckoutSummaryFeaturedList.

[StevenDufresne]

Fixes #98528.

Proposed Changes

When anything happens in the cart that triggers a form validation, the CheckoutSummaryFeaturedList goes back into a loading state.

This PR removes the loading state for CheckoutSummaryFeaturedList

Before

Screen.Capture.on.2025-01-20.at.15-22-09.mp4

After

Screen.Capture.on.2025-01-20.at.15-20-29.mp4

Why are these changes being made?

I don't believe we need the loader for two reasons:

• There aren't any long-running async calls that are made in this component or child components (I think :))
  • Even if there were, I don't think it matters.
• It's supplementary information and we don't add loading states for any of the products in the cart.
• (and the loader is visually distracting)

Why not delete LoadingCheckoutSummaryFeaturesList?

It's currently being used in the purchase modal:

wp-calypso/client/my-sites/checkout/purchase-modal/placeholder.jsx

Line 1 in 0894428

import { LoadingCheckoutSummaryFeaturesList } from '../src/components/wp-checkout-order-summary';

Why no tests?

I don't think there's anything to test. :)

Testing Instructions

We want usePrefillCheckoutContactForm to auto-select the contact because that adds the most loading lag.

• So first, create a cart with any item, go to the cart, save the contact, and then navigate away.
• Add more products to your cart (Domain + Plan)
• Go to your cart.
• Confirm that features are displayed after the initial page load.
• Make some updates to products in the cart. (Billing years)
• Notice the Feature list does not go into a loading state.
• Remove an item from your cart.
• Notice the Feature list does not go into a loading state, but does update appropriately.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130570

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130570&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130570&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~10 bytes removed 📉 [gzipped])

name      parsed_size           gzip_size
checkout        -18 B  (-0.0%)      -10 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~10 bytes removed 📉 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-page-picker                                                     -18 B  (-0.0%)      -10 B  (-0.0%)
async-load-purchase-modal-wrapper                                                       -18 B  (-0.0%)      -10 B  (-0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        -18 B  (-0.0%)      -10 B  (-0.0%)
async-load-calypso-my-sites-checkout-modal                                              -18 B  (-0.0%)      -10 B  (-0.0%)
async-load-calypso-blocks-editor-checkout-modal                                         -18 B  (-0.0%)      -10 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/include-with-plan-loading on your sandbox.

[sirbrillig]

Seems fine to me!