Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help Center: Update Was This Helpful section #98577

Merged
merged 7 commits into from
Jan 21, 2025
Merged

Help Center: Update Was This Helpful section #98577

merged 7 commits into from
Jan 21, 2025

Conversation

agrullon95
Copy link
Contributor

@agrullon95 agrullon95 commented Jan 20, 2025 •
edited by escapemanuele
Loading

Fixes: #97926

Proposed Changes

  • Updates the "Was this helpful" section after the chat AI response.
CleanShot 2025-01-20 at 11 18 43@2x

Figma design: jY4HeiXZe3NA832aCIgxFM-fi-9_22

Why are these changes being made?

  • Improve UX by updating styling to match recently updated chat.

Testing Instructions

  • Checkout branch or use live link.
  • Open the Help Center.
  • Start a new conversation and send a message, such as, "Add a domain".
  • Scroll to the "Was this Helpful" section under the AI response and compare it to the figma design.

@agrullon95 agrullon95 added the [Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens. label Jan 20, 2025
@agrullon95 agrullon95 requested a review from a team January 20, 2025 04:19
@agrullon95 agrullon95 self-assigned this Jan 20, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 20, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-130455
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-130455&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-130455&env=a8c-for-agencies

@matticbot
Copy link
Contributor

matticbot commented Jan 20, 2025 •
edited
Loading

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/hc-update-was-this-helpful on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 20, 2025 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~6 bytes added 📈 [gzipped])

name                                       parsed_size           gzip_size
async-load-automattic-help-center-stepper        +19 B  (+0.0%)       +6 B  (+0.0%)
async-load-automattic-help-center                +19 B  (+0.0%)       +6 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@escapemanuele escapemanuele self-requested a review January 20, 2025 11:50
escapemanuele
escapemanuele approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Shared some comments, after addressing them let's ship this!

escapemanuele
escapemanuele reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments 👍

packages/odie-client/src/components/message/style.scss Outdated Show resolved Hide resolved
packages/odie-client/src/components/message/style.scss Outdated Show resolved Hide resolved
@agrullon95 agrullon95 merged commit e9d697d into trunk Jan 21, 2025
13 checks passed
@agrullon95 agrullon95 deleted the update/hc-update-was-this-helpful branch January 21, 2025 14:55
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 21, 2025
JessBoctor pushed a commit that referenced this pull request Jan 22, 2025
@agrullon95
Help Center: Update Was This Helpful section (#98577)
ca35f6e 
* Refactor was this helpful section

* Fix optional chaining in Sources component for safer access to message context

* Style: Introduce variables for foldable header font size and icon color in message component

* Style: Refactor message component styles for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escapemanuele escapemanuele escapemanuele approved these changes

Assignees

@agrullon95 agrullon95

Labels
[Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Help Center: Improve "Was this Helpful" section after AI responses
3 participants
@agrullon95 @matticbot @escapemanuele