Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI alignment and spacing issue with "OR" separator between buttons for Woo 2FA screen #98575

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

chihsuan
Copy link
Member

@chihsuan chihsuan commented Jan 20, 2025

This PR addresses the spacing issues related to the "OR" separator between the 2FA action buttons.

This happens in both Production and Staging (brand update).

Before:
Screenshot 2025-01-20 at 11 44 03

After:

Screenshot 2025-01-20 at 11 51 29

Proposed Changes

  • Add 32px margin to the top of the 2FA action buttons

Why are these changes being made?

  • To match the design.

Testing Instructions

  • Checkout this branch
  • Go to WooCommerce.com
  • Click on Login
  • Enter an "email/password" account (not passwordless). If you don't have one, you can create a passwordless account and then add a password in the account settings.
  • Click on Continue
  • Observe the spacing between the 2FA action buttons is 32px

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@chihsuan chihsuan requested review from a team, moon0326 and adrianduffell January 20, 2025 04:02
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 20, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @chihsuan 🚀

@chihsuan chihsuan merged commit 8d73856 into trunk Jan 20, 2025
18 of 19 checks passed
@chihsuan chihsuan deleted the fix/woo-2fa-button-margin branch January 20, 2025 06:28
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants