Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter goal is now eligible for big sky #98574

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

p-jackson
Copy link
Member

@p-jackson p-jackson commented Jan 20, 2025

Related to #

Proposed Changes

Newsletter goals are now eligible for big sky

Why are these changes being made?

pgatNH-es-p2#comment-219

Testing Instructions

  • Must be in control group of 22138-explat-experiment experiment to see big sky option appear post checkout
  • Create a new site using a premium plan
  • Choose newsletter on the goals screen
  • The big sky option should appear

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@p-jackson p-jackson self-assigned this Jan 20, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~9 bytes removed 📉 [gzipped])

name             parsed_size           gzip_size
site-setup-wg          -13 B  (-0.0%)       -9 B  (-0.0%)
site-setup-flow        -13 B  (-0.0%)       -9 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@p-jackson p-jackson merged commit 73c8762 into trunk Jan 20, 2025
15 checks passed
@p-jackson p-jackson deleted the update/allow-big-sky-newsletter branch January 20, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants