-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Restyle receipt view for updated DataViews Billing History List #98567
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~4 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~978 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
597b22a
to
c67e0cf
Compare
Related to https://github.com/Automattic/payments-florin/issues/739
Proposed Changes
Since we're replacing the current Billing History List (receipts) with a DataViews-based component, we need to update the individual receipt page to match. This PR creates a new component to incorporate these changes.
Unlike the current receipt, this one will conditionally show the credit card that was used for this purchase if it's available. Otherwise that section will be omitted.
Why are these changes being made?
We want the updated receipt to follow this design mock-up.
AFAIK, we don't currently have PDF receipts available for customers to download so I left out the download button from the mock-up and instead included buttons to email and print the receipt.
Testing Instructions
Pre-merge Checklist