Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Restyle receipt view for updated DataViews Billing History List #98567

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

billrobbins
Copy link
Contributor

@billrobbins billrobbins commented Jan 18, 2025

Related to https://github.com/Automattic/payments-florin/issues/739

Proposed Changes

Since we're replacing the current Billing History List (receipts) with a DataViews-based component, we need to update the individual receipt page to match. This PR creates a new component to incorporate these changes.

Unlike the current receipt, this one will conditionally show the credit card that was used for this purchase if it's available. Otherwise that section will be omitted.

receipt

Why are these changes being made?

We want the updated receipt to follow this design mock-up.

Screenshot 2025-01-17 at 11 41 08 AM

AFAIK, we don't currently have PDF receipts available for customers to download so I left out the download button from the mock-up and instead included buttons to email and print the receipt.

Testing Instructions

  1. Open http://calypso.localhost:3000/me/purchases/billing in your browser.
  2. Find a purchase from the list and hover over it. On the right side, a "view receipt" button should appear. Click on that to open a receipt.
  3. Ensure that the individual receipt does not have any visual abnormalities.
  4. Click the "print" button in the top-right which should open up the print dialogue. Close it out.
  5. Enter an address in the "Billing Details" box and click the "print" button again. This time the Billing Details section should appear in the print preview.
  6. Click the "email receipt" button and check your inbox to ensure that the invoice was received as expected.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Jan 18, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug dataview-receipt-view on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 18, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~4 bytes added 📈 [gzipped])

name        parsed_size           gzip_size
entry-main       +162 B  (+0.0%)       +4 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~978 bytes added 📈 [gzipped])

name            parsed_size           gzip_size
site-purchases     +12990 B  (+0.6%)    +3759 B  (+0.6%)
purchases           +6034 B  (+0.2%)    +1113 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@billrobbins billrobbins self-assigned this Jan 21, 2025
@billrobbins billrobbins force-pushed the dataview-receipt-view branch from 597b22a to c67e0cf Compare January 23, 2025 19:45
@billrobbins billrobbins marked this pull request as ready for review January 24, 2025 20:57
@billrobbins billrobbins requested a review from a team as a code owner January 24, 2025 20:57
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants